Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5523)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 2220573004: Caption for the Subresource filter bubble prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: message Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
index 897ac77b012efe11f7e98a78baf006ded8ae63f3..bc4986718604390af7cfcdd0bf4cf06772ce7223 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
@@ -118,6 +118,7 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
std::string manage_link;
MediaMenuMap media_menus;
std::string learn_more_link;
+ std::string message;
msw 2016/08/10 17:30:54 nit: order directly after title?
melandory 2016/08/13 07:06:22 Done.
private:
DISALLOW_COPY_AND_ASSIGN(BubbleContent);
@@ -179,6 +180,9 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
Profile* profile() const { return profile_; }
Delegate* delegate() const { return delegate_; }
+ void set_message(const std::string& message) {
msw 2016/08/10 17:30:54 nit: match accessor ordering to member decl orderi
melandory 2016/08/13 07:06:22 Done.
+ bubble_content_.message = message;
+ }
void set_title(const std::string& title) { bubble_content_.title = title; }
void add_list_item(const ListItem& item) {
bubble_content_.list_items.push_back(item);
@@ -304,6 +308,8 @@ class ContentSettingSubresourceFilterBubbleModel
override;
private:
+ void SetMessage();
+
// ContentSettingBubbleModel:
void SetTitle() override;
void SetManageLink() override;

Powered by Google App Engine
This is Rietveld 408576698