Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/ui/views/content_setting_bubble_contents.cc

Issue 2220573004: Caption for the Subresource filter bubble prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: xib Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/content_setting_bubble_contents.cc
diff --git a/chrome/browser/ui/views/content_setting_bubble_contents.cc b/chrome/browser/ui/views/content_setting_bubble_contents.cc
index da0754f3db9c9fb1f7932ea737b5f6cb7e290f75..4579eda8eae68190bc93a18f6209c5027a1390be 100644
--- a/chrome/browser/ui/views/content_setting_bubble_contents.cc
+++ b/chrome/browser/ui/views/content_setting_bubble_contents.cc
@@ -202,6 +202,19 @@ void ContentSettingBubbleContents::Init() {
content_setting_bubble_model_->bubble_content();
bool bubble_content_empty = true;
+ if (!bubble_content.caption.empty()) {
+ views::Label* caption_label =
+ new views::Label(base::UTF8ToUTF16(bubble_content.caption));
+ caption_label->SetMultiLine(false);
msw 2016/08/09 19:46:54 Why not allow multi-line? Will this work alright f
melandory 2016/08/10 14:55:07 Done.
+ caption_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+ ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+ caption_label->SetFontList(rb.GetFontList(ui::ResourceBundle::MediumFont));
+ layout->StartRow(0, kSingleColumnSetId);
+ layout->AddView(caption_label);
+ layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
+ bubble_content_empty = false;
+ }
+
if (!bubble_content.title.empty()) {
views::Label* title_label = new views::Label(base::UTF8ToUTF16(
bubble_content.title));

Powered by Google App Engine
This is Rietveld 408576698