Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4046)

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model.h

Issue 2220573004: Caption for the Subresource filter bubble prompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/content_settings/content_setting_bubble_model.h
diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model.h b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
index 1105d5720863513c848573a2158c7ebe2b1423bb..315de036d637d90ca00b450ace756c863894d29c 100644
--- a/chrome/browser/ui/content_settings/content_setting_bubble_model.h
+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model.h
@@ -112,7 +112,8 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
BubbleContent();
~BubbleContent();
- std::string title;
+ base::string16 title;
+ base::string16 message;
ListItems list_items;
RadioGroup radio_group;
bool radio_group_enabled;
@@ -188,7 +189,10 @@ class ContentSettingBubbleModel : public content::NotificationObserver {
Profile* profile() const { return profile_; }
Delegate* delegate() const { return delegate_; }
- void set_title(const std::string& title) { bubble_content_.title = title; }
+ void set_title(const base::string16& title) { bubble_content_.title = title; }
+ void set_message(const base::string16& message) {
+ bubble_content_.message = message;
+ }
void add_list_item(const ListItem& item) {
bubble_content_.list_items.push_back(item);
}
@@ -316,6 +320,8 @@ class ContentSettingSubresourceFilterBubbleModel
override;
private:
+ void SetMessage();
+
// ContentSettingBubbleModel:
void SetTitle() override;
void SetManageLink() override;

Powered by Google App Engine
This is Rietveld 408576698