Add count of exclusively covered digests to each ignore rule

Add count of exclusively covered digests to each ignore rule

This adds a column to the list of ignore rules that shows the number of digests exclusively covered by that rule (and no other rule). It has to be always smaller or the same as the already existing count of digests covered by the rule. 

This is the first of two CL's. The next will add the ability to search for the digests that match this criterion. 

BUG=skia:5613
Committed: https://skia.googlesource.com/buildbot/+/3f5f8aa35f2aa6823b6a24e659412ea77beb1a20

[stephana, 2016-08-05 18:37:28]

The CQ bit was checked by stephana@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 18:37:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:42:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:42:28]

Dry run: This issue passed the CQ dry run.

[stephana, 2016-08-05 18:46:24]

Description was changed from

==========
Add count of exclusively covered digests to each ignore rule


BUG=skia:5613
==========

to

==========
Add count of exclusively covered digests to each ignore rule

This adds a column to the list of ignore rules that shows the number of digests
exclusively covered by that rule (and no other rule). It has to be always
smaller or the same as the already existing count of digests covered by the
rule. 

This is the first of two CL's. The next will add the ability to search for the
digests that match this criterion. 

BUG=skia:5613
==========

[stephana, 2016-08-05 18:46:24]

stephana@google.com changed reviewers:
+ jcgregorio@google.com, mtklein@google.com

[jcgregorio, 2016-08-05 19:12:06]

https://codereview.chromium.org/2220573003/diff/1/golden/go/ignore/sqlignores...
File golden/go/ignore/sqlignorestore.go (right):

https://codereview.chromium.org/2220573003/diff/1/golden/go/ignore/sqlignores...
golden/go/ignore/sqlignorestore.go:175: r.ExclusiveCount = 0
Needs unit test coverage.

[stephana, 2016-08-05 19:46:21]

https://codereview.chromium.org/2220573003/diff/1/golden/go/ignore/sqlignores...
File golden/go/ignore/sqlignorestore.go (right):

https://codereview.chromium.org/2220573003/diff/1/golden/go/ignore/sqlignores...
golden/go/ignore/sqlignorestore.go:175: r.ExclusiveCount = 0
On 2016/08/05 19:12:06, jcgregorio wrote:
> Needs unit test coverage.

Agreed. There is a TODO above this method that mentions that. 
It's still an unsolved problem that I will tackle together with unit tests for
the search package (since it's essentially the same problem). A few things have
to be cleaned up before then.

[mtklein, 2016-08-05 21:37:57]

Thanks!  This does look like what I was hoping for.

https://codereview.chromium.org/2220573003/diff/1/golden/frontend/res/imp/ign...
File golden/frontend/res/imp/ignores-page-sk.html (right):

https://codereview.chromium.org/2220573003/diff/1/golden/frontend/res/imp/ign...
golden/frontend/res/imp/ignores-page-sk.html:128: <div
id=exCountHeader>Exclusive</div>
Exclusively ignored?
Ignored by only this rule?

[stephana, 2016-08-08 15:13:53]

https://codereview.chromium.org/2220573003/diff/1/golden/frontend/res/imp/ign...
File golden/frontend/res/imp/ignores-page-sk.html (right):

https://codereview.chromium.org/2220573003/diff/1/golden/frontend/res/imp/ign...
golden/frontend/res/imp/ignores-page-sk.html:128: <div
id=exCountHeader>Exclusive</div>
On 2016/08/05 21:37:57, mtklein wrote:
> Exclusively ignored?
> Ignored by only this rule?

I don't think there is a good wording for the header alone. 
So I collapsed the two values into one column and added a tooltip to the header.

See

https://screenshot.googleplex.com/T3RsDzSjz10.png

[mtklein, 2016-08-08 15:26:44]

That order might want to swap, so it's a fraction up to 1?

[jcgregorio, 2016-08-08 15:55:14]

lgtm

[stephana, 2016-08-08 16:17:35]

The CQ bit was checked by stephana@google.com

[commit-bot: I haz the power, 2016-08-08 16:17:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stephana, 2016-08-08 16:18:35]

The CQ bit was unchecked by stephana@google.com

[stephana, 2016-08-08 16:44:23]

On 2016/08/08 16:17:48, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Swapped the counts as per mtklein's suggestion.

[stephana, 2016-08-08 16:44:26]

The CQ bit was checked by stephana@google.com

[stephana, 2016-08-08 16:44:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcgregorio@google.com
Link to the patchset: https://codereview.chromium.org/2220573003/#ps40001
(title: "Swapped counts")

[commit-bot: I haz the power, 2016-08-08 16:44:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:55:33]

Description was changed from

==========
Add count of exclusively covered digests to each ignore rule

This adds a column to the list of ignore rules that shows the number of digests
exclusively covered by that rule (and no other rule). It has to be always
smaller or the same as the already existing count of digests covered by the
rule. 

This is the first of two CL's. The next will add the ability to search for the
digests that match this criterion. 

BUG=skia:5613
==========

to

==========
Add count of exclusively covered digests to each ignore rule

This adds a column to the list of ignore rules that shows the number of digests
exclusively covered by that rule (and no other rule). It has to be always
smaller or the same as the already existing count of digests covered by the
rule. 

This is the first of two CL's. The next will add the ability to search for the
digests that match this criterion. 

BUG=skia:5613

Committed:
https://skia.googlesource.com/buildbot/+/3f5f8aa35f2aa6823b6a24e659412ea77beb...
==========

[commit-bot: I haz the power, 2016-08-08 16:55:34]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/buildbot/+/3f5f8aa35f2aa6823b6a24e659412ea77beb...