third_party/WebKit/Source/platform/SharedBufferChunkReader.h - Issue 2220543002: Make Resource::resourceBuffer() to return PassRefPtr<const SharedBuffer>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/SharedBufferChunkReader.h

Issue 2220543002: Make Resource::resourceBuffer() to return PassRefPtr<const SharedBuffer> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WTF_UseIsConvertibleInEnsure

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/SerializedResource.h ('k') | third_party/WebKit/Source/platform/SharedBufferChunkReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/SharedBufferChunkReader.h

diff --git a/third_party/WebKit/Source/platform/SharedBufferChunkReader.h b/third_party/WebKit/Source/platform/SharedBufferChunkReader.h

index 2ecc03b6e2b163ea0f147f94ea755388d3fea8cf..7823d067edfc766827440cb82cc1f6670edbcf10 100644

--- a/third_party/WebKit/Source/platform/SharedBufferChunkReader.h

+++ b/third_party/WebKit/Source/platform/SharedBufferChunkReader.h

@@ -45,8 +45,8 @@ class PLATFORM_EXPORT SharedBufferChunkReader final {

DISALLOW_NEW();

WTF_MAKE_NONCOPYABLE(SharedBufferChunkReader);

public:

- SharedBufferChunkReader(PassRefPtr<SharedBuffer>, const Vector<char>& separator);

- SharedBufferChunkReader(PassRefPtr<SharedBuffer>, const char* separator);

+ SharedBufferChunkReader(PassRefPtr<const SharedBuffer>, const Vector<char>& separator);

+ SharedBufferChunkReader(PassRefPtr<const SharedBuffer>, const char* separator);

void setSeparator(const Vector<char>&);

void setSeparator(const char*);

@@ -62,7 +62,7 @@ public:

size_t peek(Vector<char>&, size_t);

private:

- RefPtr<SharedBuffer> m_buffer;

+ RefPtr<const SharedBuffer> m_buffer;

size_t m_bufferPosition;

const char* m_segment;

size_t m_segmentLength;