Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2220513002: Revert of [turbofan] Add support for copy-on-write element stores. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Add support for copy-on-write element stores. (patchset #2 id:20001 of https://codereview.chromium.org/2218703003/ ) Reason for revert: Breaks tree? Original issue's description: > [turbofan] Add support for copy-on-write element stores. > > This extends JSNativeContextSpecialization with support for stores to > fast object/smi element backing stores that are marked as copy-on-write. > In this case we first call the CopyFixedArray builtin to take a copy of > the elements backing store, and then store the new elements back to the > object, and finally perform the actual element store. > > R=epertoso@chromium.org > BUG=v8:4470 > > Committed: https://crrev.com/ac98ad22f049a59c48387f1bab1590f135d219c6 > Cr-Commit-Position: refs/heads/master@{#38370} TBR=epertoso@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470 Committed: https://crrev.com/d3d7069d380f35a6e775eb33da36597722558919 Cr-Commit-Position: refs/heads/master@{#38376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -321 lines) Patch
M src/builtins/builtins.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins/builtins-internal.cc View 2 chunks +1 line, -120 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +0 lines, -56 lines 0 comments Download
M src/compiler/js-graph.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/js-graph.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 4 chunks +5 lines, -18 lines 0 comments Download
M src/compiler/load-elimination.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/compiler/load-elimination.cc View 5 chunks +0 lines, -44 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +0 lines, -7 lines 0 comments Download
M test/unittests/compiler/load-elimination-unittest.cc View 8 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
Created Revert of [turbofan] Add support for copy-on-write element stores.
4 years, 4 months ago (2016-08-05 12:01:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220513002/1
4 years, 4 months ago (2016-08-05 12:01:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 12:03:07 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 12:07:10 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3d7069d380f35a6e775eb33da36597722558919
Cr-Commit-Position: refs/heads/master@{#38376}

Powered by Google App Engine
This is Rietveld 408576698