Code cleanup in blink::SpellChecker

Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
constant at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed, and
some other convoluted code is simplified.

BUG=619452
TEST=n/a; no visible change

Committed: https://crrev.com/b9f7be89f809441cba6aa4ff88e39bc967c0bcd5
Cr-Commit-Position: refs/heads/master@{#410290}

[Xiaocheng, 2016-08-05 10:46:07]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 10:46:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-05 10:51:45]

Description was changed from

==========
Code cleanup in blink::SpellChecker

BUG=619452
TEST=n/a; no visible change
==========

to

==========
Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed.

BUG=619452
TEST=n/a; no visible change
==========

[Xiaocheng, 2016-08-05 10:52:45]

Description was changed from

==========
Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed.

BUG=619452
TEST=n/a; no visible change
==========

to

==========
Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
constant at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed.

BUG=619452
TEST=n/a; no visible change
==========

[Xiaocheng, 2016-08-05 10:56:11]

Description was changed from

==========
Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
constant at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed.

BUG=619452
TEST=n/a; no visible change
==========

to

==========
Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
constant at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed, and
some other convoluted code is simplified.

BUG=619452
TEST=n/a; no visible change
==========

[commit-bot: I haz the power, 2016-08-05 12:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 12:02:13]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-05 12:09:13]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-05 12:09:13]

PTAL.

This patch is a conservative refactoring to reduce the code complexity in
SpellChecker.cpp as a preparation for the upcoming cleanup related to unified
text checker.

[yosin_UTC9, 2016-08-08 01:12:30]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-08-08 01:12:31]

lgtm

[commit-bot: I haz the power, 2016-08-08 01:12:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 02:22:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-08 02:26:14]

Description was changed from

==========
Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
constant at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed, and
some other convoluted code is simplified.

BUG=619452
TEST=n/a; no visible change
==========

to

==========
Code cleanup in blink::SpellChecker

This patch consists of the following cleanup:

1. In markMisspellingsAfterLineBreak(), is does not make sense to check
only grammar but not spelling. The behavior is changed to do nothing if
isContinuousSpellCheckingEnabled() returns false.

2. Parameter |bool markGrammar| is removed from markMisspellingsAndBadGrammar()
because its value is always equal to isContinuousSpellCheckingEnabled() at
every call site.

3. Parameter |TextCheckingTypeMask textCheckingOptions| is removed from
markAllMisspellingsAndBadGrammarInRanges() and
chunkAndMarkAllMisspellingsAndBadGrammar() because its value is the same
constant at all call sites.

4. The useless member function resolveTextCheckingTypeMask() is removed, and
some other convoluted code is simplified.

BUG=619452
TEST=n/a; no visible change

Committed: https://crrev.com/b9f7be89f809441cba6aa4ff88e39bc967c0bcd5
Cr-Commit-Position: refs/heads/master@{#410290}
==========

[commit-bot: I haz the power, 2016-08-08 02:26:15]

Patchset 1 (id:??) landed as
https://crrev.com/b9f7be89f809441cba6aa4ff88e39bc967c0bcd5
Cr-Commit-Position: refs/heads/master@{#410290}