Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Side by Side Diff: src/compiler/x64/instruction-selector-x64.cc

Issue 2220483003: [x64] Zero/sign-extend loads to 64-bit registers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed a couple of wrong assertions. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/x64/instruction-scheduler-x64.cc ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 6
7 #include "src/base/adapters.h" 7 #include "src/base/adapters.h"
8 #include "src/compiler/instruction-selector-impl.h" 8 #include "src/compiler/instruction-selector-impl.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/node-properties.h" 10 #include "src/compiler/node-properties.h"
(...skipping 1094 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 if (success_output) { 1105 if (success_output) {
1106 outputs[output_count++] = g.DefineAsRegister(success_output); 1106 outputs[output_count++] = g.DefineAsRegister(success_output);
1107 } 1107 }
1108 1108
1109 Emit(kSSEFloat64ToUint64, output_count, outputs, 1, inputs); 1109 Emit(kSSEFloat64ToUint64, output_count, outputs, 1, inputs);
1110 } 1110 }
1111 1111
1112 1112
1113 void InstructionSelector::VisitChangeInt32ToInt64(Node* node) { 1113 void InstructionSelector::VisitChangeInt32ToInt64(Node* node) {
1114 X64OperandGenerator g(this); 1114 X64OperandGenerator g(this);
1115 Emit(kX64Movsxlq, g.DefineAsRegister(node), g.Use(node->InputAt(0))); 1115 Node* const value = node->InputAt(0);
1116 if (value->opcode() == IrOpcode::kLoad && CanCover(node, value)) {
1117 LoadRepresentation load_rep = LoadRepresentationOf(value->op());
1118 MachineRepresentation rep = load_rep.representation();
1119 InstructionCode opcode = kArchNop;
1120 switch (rep) {
1121 case MachineRepresentation::kBit: // Fall through.
1122 case MachineRepresentation::kWord8:
1123 opcode = load_rep.IsSigned() ? kX64Movsxbq : kX64Movzxbq;
1124 break;
1125 case MachineRepresentation::kWord16:
1126 opcode = load_rep.IsSigned() ? kX64Movsxwq : kX64Movzxwq;
1127 break;
1128 case MachineRepresentation::kWord32:
1129 opcode = load_rep.IsSigned() ? kX64Movsxlq : kX64Movl;
1130 break;
1131 default:
1132 UNREACHABLE();
1133 return;
1134 }
1135 InstructionOperand outputs[] = {g.DefineAsRegister(node)};
1136 size_t input_count = 0;
1137 InstructionOperand inputs[3];
1138 AddressingMode mode = g.GetEffectiveAddressMemoryOperand(
1139 node->InputAt(0), inputs, &input_count);
1140 opcode |= AddressingModeField::encode(mode);
1141 Emit(opcode, 1, outputs, input_count, inputs);
1142 } else {
1143 Emit(kX64Movsxlq, g.DefineAsRegister(node), g.Use(node->InputAt(0)));
1144 }
1116 } 1145 }
1117 1146
1118 1147
1119 void InstructionSelector::VisitChangeUint32ToUint64(Node* node) { 1148 void InstructionSelector::VisitChangeUint32ToUint64(Node* node) {
1120 X64OperandGenerator g(this); 1149 X64OperandGenerator g(this);
1121 Node* value = node->InputAt(0); 1150 Node* value = node->InputAt(0);
1122 switch (value->opcode()) { 1151 switch (value->opcode()) {
1123 case IrOpcode::kWord32And: 1152 case IrOpcode::kWord32And:
1124 case IrOpcode::kWord32Or: 1153 case IrOpcode::kWord32Or:
1125 case IrOpcode::kWord32Xor: 1154 case IrOpcode::kWord32Xor:
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
2207 // static 2236 // static
2208 MachineOperatorBuilder::AlignmentRequirements 2237 MachineOperatorBuilder::AlignmentRequirements
2209 InstructionSelector::AlignmentRequirements() { 2238 InstructionSelector::AlignmentRequirements() {
2210 return MachineOperatorBuilder::AlignmentRequirements:: 2239 return MachineOperatorBuilder::AlignmentRequirements::
2211 FullUnalignedAccessSupport(); 2240 FullUnalignedAccessSupport();
2212 } 2241 }
2213 2242
2214 } // namespace compiler 2243 } // namespace compiler
2215 } // namespace internal 2244 } // namespace internal
2216 } // namespace v8 2245 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/x64/instruction-scheduler-x64.cc ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698