Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2203)

Side by Side Diff: src/compiler/x64/code-generator-x64.cc

Issue 2220483003: [x64] Zero/sign-extend loads to 64-bit registers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed a couple of wrong assertions. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/x64/instruction-codes-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 1736 matching lines...) Expand 10 before | Expand all | Expand 10 after
1747 __ Subsd(i.InputDoubleRegister(0), kScratchDoubleReg); 1747 __ Subsd(i.InputDoubleRegister(0), kScratchDoubleReg);
1748 break; 1748 break;
1749 case kX64Movsxbl: 1749 case kX64Movsxbl:
1750 ASSEMBLE_MOVX(movsxbl); 1750 ASSEMBLE_MOVX(movsxbl);
1751 __ AssertZeroExtended(i.OutputRegister()); 1751 __ AssertZeroExtended(i.OutputRegister());
1752 break; 1752 break;
1753 case kX64Movzxbl: 1753 case kX64Movzxbl:
1754 ASSEMBLE_MOVX(movzxbl); 1754 ASSEMBLE_MOVX(movzxbl);
1755 __ AssertZeroExtended(i.OutputRegister()); 1755 __ AssertZeroExtended(i.OutputRegister());
1756 break; 1756 break;
1757 case kX64Movsxbq:
1758 ASSEMBLE_MOVX(movsxbq);
1759 break;
1760 case kX64Movzxbq:
1761 ASSEMBLE_MOVX(movzxbq);
1762 __ AssertZeroExtended(i.OutputRegister());
1763 break;
1757 case kX64Movb: { 1764 case kX64Movb: {
1758 size_t index = 0; 1765 size_t index = 0;
1759 Operand operand = i.MemoryOperand(&index); 1766 Operand operand = i.MemoryOperand(&index);
1760 if (HasImmediateInput(instr, index)) { 1767 if (HasImmediateInput(instr, index)) {
1761 __ movb(operand, Immediate(i.InputInt8(index))); 1768 __ movb(operand, Immediate(i.InputInt8(index)));
1762 } else { 1769 } else {
1763 __ movb(operand, i.InputRegister(index)); 1770 __ movb(operand, i.InputRegister(index));
1764 } 1771 }
1765 break; 1772 break;
1766 } 1773 }
1767 case kX64Movsxwl: 1774 case kX64Movsxwl:
1768 ASSEMBLE_MOVX(movsxwl); 1775 ASSEMBLE_MOVX(movsxwl);
1769 __ AssertZeroExtended(i.OutputRegister()); 1776 __ AssertZeroExtended(i.OutputRegister());
1770 break; 1777 break;
1771 case kX64Movzxwl: 1778 case kX64Movzxwl:
1772 ASSEMBLE_MOVX(movzxwl); 1779 ASSEMBLE_MOVX(movzxwl);
1773 __ AssertZeroExtended(i.OutputRegister()); 1780 __ AssertZeroExtended(i.OutputRegister());
1774 break; 1781 break;
1782 case kX64Movsxwq:
1783 ASSEMBLE_MOVX(movsxwq);
1784 break;
1785 case kX64Movzxwq:
1786 ASSEMBLE_MOVX(movzxwq);
1787 __ AssertZeroExtended(i.OutputRegister());
1788 break;
1775 case kX64Movw: { 1789 case kX64Movw: {
1776 size_t index = 0; 1790 size_t index = 0;
1777 Operand operand = i.MemoryOperand(&index); 1791 Operand operand = i.MemoryOperand(&index);
1778 if (HasImmediateInput(instr, index)) { 1792 if (HasImmediateInput(instr, index)) {
1779 __ movw(operand, Immediate(i.InputInt16(index))); 1793 __ movw(operand, Immediate(i.InputInt16(index)));
1780 } else { 1794 } else {
1781 __ movw(operand, i.InputRegister(index)); 1795 __ movw(operand, i.InputRegister(index));
1782 } 1796 }
1783 break; 1797 break;
1784 } 1798 }
(...skipping 807 matching lines...) Expand 10 before | Expand all | Expand 10 after
2592 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc; 2606 int padding_size = last_lazy_deopt_pc_ + space_needed - current_pc;
2593 __ Nop(padding_size); 2607 __ Nop(padding_size);
2594 } 2608 }
2595 } 2609 }
2596 2610
2597 #undef __ 2611 #undef __
2598 2612
2599 } // namespace compiler 2613 } // namespace compiler
2600 } // namespace internal 2614 } // namespace internal
2601 } // namespace v8 2615 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/x64/instruction-codes-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698