Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Issue 2220423004: Revert of Include non-composited layout views in existing workaround for clipping changes. (Closed)

Created:
4 years, 4 months ago by foolip
Modified:
4 years, 4 months ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include non-composited layout views in existing workaround for clipping changes. (patchset #3 id:40001 of https://codereview.chromium.org/2212403004/ ) Reason for revert: fast/repaint/resize-iframe-text.html is failing on Mac and Win. The CL was landed with [ NeedsRebaseline ], so also remove the platform expectations added with https://codereview.chromium.org/2221693002 BUG=635892 Original issue's description: > Include non-composited layout views in existing workaround for clipping changes. > > BUG=633869 > > Committed: https://crrev.com/74d1e73747b73764b50dfaf413344397c14b971f > Cr-Commit-Position: refs/heads/master@{#410222} TBR=chrishtr@chromium.org,wkorman@chromium.org BUG=633869 Committed: https://chromium.googlesource.com/chromium/src/+/ee0c98a9d507510dbb7023b38fab8f786e882e11

Patch Set 1 #

Patch Set 2 : also remove platform expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -532 lines) Patch
D third_party/WebKit/LayoutTests/fast/repaint/resize-iframe-text.html View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/repaint/resources/resize-iframe-text-src.html View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/fast/repaint/resize-iframe-text-expected.txt View 1 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/repaint/resize-iframe-text-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/repaint/resize-iframe-text-expected.txt View 1 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-retina/fast/repaint/resize-iframe-text-expected.txt View 1 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/fast/repaint/resize-iframe-text-expected.txt View 1 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.png View 1 Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/fast/repaint/resize-iframe-text-expected.txt View 1 1 chunk +0 lines, -110 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/fast/repaint/resize-iframe-text-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
foolip
Created Revert of Include non-composited layout views in existing workaround for clipping changes.
4 years, 4 months ago (2016-08-09 13:38:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220423004/1
4 years, 4 months ago (2016-08-09 13:38:30 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ee0c98a9d507510dbb7023b38fab8f786e882e11 Cr-Commit-Position: refs/heads/master@{#410652}
4 years, 4 months ago (2016-08-09 13:50:30 UTC) #9
foolip
4 years, 4 months ago (2016-08-09 13:51:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:170001) manually as
ee0c98a9d507510dbb7023b38fab8f786e882e11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698