Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 2220423002: Fix sync-credential-related metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix PasswordFormManagerTest.ReportProcessingUpdate Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index b294ad38ca682431fa2fede85b230a75e3c20295..16731e6ade9bd3fa8fd17972aee08552c52e07bf 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -14,6 +14,7 @@
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/histogram_tester.h"
+#include "base/test/user_action_tester.h"
#include "build/build_config.h"
#include "components/autofill/core/browser/autofill_manager.h"
#include "components/autofill/core/browser/proto/server.pb.h"
@@ -3026,4 +3027,22 @@ TEST_F(PasswordFormManagerFillOnAccountSelectTest, ProcessFrame) {
SimulateMatchingPhase(form_manager(), RESULT_SAVED_MATCH);
}
+// Check that PasswordFormManager records PasswordManager_ProcessingUpdate as
+// part of processing a credential update.
+TEST_F(PasswordFormManagerTest, ReportProcessingUpdate) {
+ SimulateMatchingPhase(form_manager(), RESULT_SAVED_MATCH);
+ PasswordForm pending = *observed_form();
+ pending.username_value = saved_match()->username_value;
+ pending.password_value = saved_match()->password_value;
+ form_manager()->ProvisionallySave(
+ pending, PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
+
+ EXPECT_FALSE(form_manager()->IsNewLogin());
+
+ base::UserActionTester tester;
+ EXPECT_EQ(0, tester.GetActionCount("PasswordManager_ProcessingUpdate"));
+ form_manager()->Update(*saved_match());
+ EXPECT_EQ(1, tester.GetActionCount("PasswordManager_ProcessingUpdate"));
+}
+
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698