components/password_manager/sync/browser/sync_credentials_filter.h - Issue 2220423002: Fix sync-credential-related metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/sync_credentials_filter.h

Issue 2220423002: Fix sync-credential-related metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Non-null driver + removing a forgotten LOG statement Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/sync/browser/sync_credentials_filter.h

diff --git a/components/password_manager/sync/browser/sync_credentials_filter.h b/components/password_manager/sync/browser/sync_credentials_filter.h

index 019a28c2c318ac6b3790e186c364ecad1edacb0d..4ad64f31db77a87ca449062b09a88fd029931906 100644

--- a/components/password_manager/sync/browser/sync_credentials_filter.h

+++ b/components/password_manager/sync/browser/sync_credentials_filter.h

@@ -41,7 +41,8 @@ class SyncCredentialsFilter : public CredentialsFilter {

ScopedVector<autofill::PasswordForm> FilterResults(

ScopedVector<autofill::PasswordForm> results) const override;

bool ShouldSave(const autofill::PasswordForm& form) const override;

- void ReportFormUsed(const autofill::PasswordForm& form) const override;

+ void ReportFormLoginSuccess(

+ const PasswordFormManager& form_manager) const override;

private:

enum AutofillForSyncCredentialsState {