components/password_manager/core/browser/password_form_manager.cc - Issue 2220423002: Fix sync-credential-related metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 2220423002: Fix sync-credential-related metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Non-null driver + removing a forgotten LOG statement Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index cb39586bb887357910763c82ca470683c6882c74..14fee4e1d1ab1ecc8ac6fe7ea30974e293066635 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -685,7 +685,8 @@ void PasswordFormManager::ProcessUpdate() {

UpdateMetadataForUsage(&pending_credentials_);

- client_->GetStoreResultFilter()->ReportFormUsed(pending_credentials_);

+ base::RecordAction(

+ base::UserMetricsAction("PasswordManager_ProcessingUpdate"));

// Check to see if this form is a candidate for password generation.

// Do not send votes on change password forms, since they were already sent in