components/password_manager/core/browser/password_manager.cc - Issue 2220423002: Fix sync-credential-related metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 2220423002: Fix sync-credential-related metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments addressed Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index ce5041839346aba2433af4938a386e007c989095..9ff8674d704108ae1e6176308e45bb8705384674 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -676,6 +676,9 @@ void PasswordManager::OnLoginSuccessful() {

logger->LogMessage(Logger::STRING_ON_ASK_USER_OR_SAVE_PASSWORD);

}

+ client_->GetStoreResultFilter()->ReportFormLoginSuccess(

+ *provisional_save_manager_);

if (base::FeatureList::IsEnabled(features::kDropSyncCredential) &&

!client_->GetStoreResultFilter()->ShouldSave(

provisional_save_manager_->pending_credentials())) {