Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: components/password_manager/core/browser/credentials_filter.h

Issue 2220423002: Fix sync-credential-related metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/credentials_filter.h
diff --git a/components/password_manager/core/browser/credentials_filter.h b/components/password_manager/core/browser/credentials_filter.h
index 2b336de64564ab3cc8bc1205de5860a1f35a68c7..0658121af0890b6df54121543baa4008519986d7 100644
--- a/components/password_manager/core/browser/credentials_filter.h
+++ b/components/password_manager/core/browser/credentials_filter.h
@@ -11,6 +11,8 @@
namespace password_manager {
+class PasswordFormManager;
+
// This interface is used to filter credentials during saving, retrieval from
// PasswordStore, etc.
class CredentialsFilter {
@@ -26,9 +28,10 @@ class CredentialsFilter {
// Should |form| be offered to be saved?
virtual bool ShouldSave(const autofill::PasswordForm& form) const = 0;
- // Call this if |form| was filled, and the subsequent sign-in looked like a
- // success. Calling is optional, used only for statistics.
- virtual void ReportFormUsed(const autofill::PasswordForm& form) const {}
+ // Call this if the form associated with |form_manager| was filled, and the
+ // subsequent sign-in looked like a success.
+ virtual void ReportFormLoginSuccess(
+ const PasswordFormManager& form_manager) const {}
private:
DISALLOW_COPY_AND_ASSIGN(CredentialsFilter);
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698