Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2220403002:
MD Settings Desktop: Change 'Reset to ask' label to 'Remove'. (Closed)
DescriptionMD Settings Desktop: Change 'Reset to ask' label to 'Remove'.
BUG=543635
Committed: https://crrev.com/2f994367d833fcc4344b1010dbd2c797beb2a030
Cr-Commit-Position: refs/heads/master@{#410721}
Patch Set 1 #Patch Set 2 : Tests #
Total comments: 2
Patch Set 3 : Polish #
Messages
Total messages: 24 (16 generated)
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
finnur@chromium.org changed reviewers: + dschuyler@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2220403002/diff/20001/chrome/app/settings_str... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2220403002/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:1326: <message name="IDS_SETTINGS_SITE_SETTINGS_RESET_MENU" desc="Label for the menu item to reset the permission for a particular site (make it ask you again next time)."> The IDS_ label and description are still talking about reset. So a translation may sill refer to it as resetting (or whatever the translation is for resetting). Should we change the translation instructions or is there a reason not to change them?
Feel free to check the commit button if this looks ok. https://codereview.chromium.org/2220403002/diff/20001/chrome/app/settings_str... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2220403002/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:1326: <message name="IDS_SETTINGS_SITE_SETTINGS_RESET_MENU" desc="Label for the menu item to reset the permission for a particular site (make it ask you again next time)."> I was on the fence when I wrote it. In any case this is just a reset, it is just a question of how you word it, but I guess there's no harm in changing the translation instructions to match.
The CQ bit was checked by finnur@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== MD Settings Desktop: Change 'Reset to ask' label to 'Remove'. BUG=543635 ========== to ========== MD Settings Desktop: Change 'Reset to ask' label to 'Remove'. BUG=543635 Committed: https://crrev.com/2f994367d833fcc4344b1010dbd2c797beb2a030 Cr-Commit-Position: refs/heads/master@{#410721} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2f994367d833fcc4344b1010dbd2c797beb2a030 Cr-Commit-Position: refs/heads/master@{#410721}
Message was sent while issue was closed.
suriyas833@gmail.com changed reviewers: + SuriyaS833@gmail.com
Message was sent while issue was closed.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
