 Chromium Code Reviews
 Chromium Code Reviews Issue 2220373003:
  Allow botlist API call to respond to quarantined: and is_dead:  (Closed) 
  Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
    
  
    Issue 2220373003:
  Allow botlist API call to respond to quarantined: and is_dead:  (Closed) 
  Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master| Index: appengine/swarming/swarming_rpcs.py | 
| diff --git a/appengine/swarming/swarming_rpcs.py b/appengine/swarming/swarming_rpcs.py | 
| index e000c40a23e95d38870f85a7ca1422ca8a11a0a1..10854b1955e1eab7a3bcf1129ad159efb27c897e 100644 | 
| --- a/appengine/swarming/swarming_rpcs.py | 
| +++ b/appengine/swarming/swarming_rpcs.py | 
| @@ -48,6 +48,17 @@ class StringListPair(messages.Message): | 
| value = messages.StringField(2, repeated=True) | 
| +class ThreeStateBool(messages.Enum): | 
| + FALSE = 1 | 
| + TRUE = 2 | 
| + NONE = 3 | 
| + | 
| 
M-A Ruel
2016/08/09 18:05:27
two empty lines between file level symbols.
 
kjlubick
2016/08/09 19:25:03
Done.
 | 
| +def to_bool(three_state): | 
| 
M-A Ruel
2016/08/09 18:05:27
you could add:
if three_state in (None, True, Fal
 
kjlubick
2016/08/09 19:25:03
Done.
 | 
| + if three_state == ThreeStateBool.FALSE: | 
| + return False | 
| + if three_state == ThreeStateBool.TRUE: | 
| + return True | 
| + | 
| ### Server related. | 
| @@ -308,6 +319,8 @@ class BotsRequest(messages.Message): | 
| # Must be a list of 'key:value' strings to filter the returned list of bots | 
| # on. | 
| dimensions = messages.StringField(3, repeated=True) | 
| + quarantined = messages.EnumField(ThreeStateBool, 4, default='NONE') | 
| + is_dead = messages.EnumField(ThreeStateBool, 5, default='NONE') | 
| class BotEventsRequest(messages.Message): |