 Chromium Code Reviews
 Chromium Code Reviews Issue 2220373003:
  Allow botlist API call to respond to quarantined: and is_dead:  (Closed) 
  Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
    
  
    Issue 2220373003:
  Allow botlist API call to respond to quarantined: and is_dead:  (Closed) 
  Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master| Index: appengine/swarming/swarming_rpcs.py | 
| diff --git a/appengine/swarming/swarming_rpcs.py b/appengine/swarming/swarming_rpcs.py | 
| index e000c40a23e95d38870f85a7ca1422ca8a11a0a1..eb4ab32c2be3afe8383d364f7c3b309c123ab0b4 100644 | 
| --- a/appengine/swarming/swarming_rpcs.py | 
| +++ b/appengine/swarming/swarming_rpcs.py | 
| @@ -48,6 +48,20 @@ class StringListPair(messages.Message): | 
| value = messages.StringField(2, repeated=True) | 
| +class ThreeStateBool(messages.Enum): | 
| + FALSE = 1 | 
| + TRUE = 2 | 
| + NONE = 3 | 
| + | 
| + | 
| +def to_bool(three_state): | 
| + if three_state in (None, True, False): | 
| + return three_state | 
| + if three_state == ThreeStateBool.FALSE: | 
| + return False | 
| + if three_state == ThreeStateBool.TRUE: | 
| + return True | 
| + | 
| 
M-A Ruel
2016/08/09 20:23:13
2 lines here
 
kjlubick
2016/08/09 20:44:44
Done.
 | 
| ### Server related. | 
| @@ -308,6 +322,8 @@ class BotsRequest(messages.Message): | 
| # Must be a list of 'key:value' strings to filter the returned list of bots | 
| # on. | 
| dimensions = messages.StringField(3, repeated=True) | 
| + quarantined = messages.EnumField(ThreeStateBool, 4, default='NONE') | 
| + is_dead = messages.EnumField(ThreeStateBool, 5, default='NONE') | 
| class BotEventsRequest(messages.Message): |