Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2220373002: Reapply fast-URI patch. (Closed)

Created:
4 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
4 years, 4 months ago
Reviewers:
Bill Hesse, floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix bug in SimpleUri.replace where ? was included in the result's query. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3370 lines, -2017 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/util/fast_uri.dart View 1 chunk +1 line, -17 lines 0 comments Download
M runtime/lib/uri_patch.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/core_patch.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M sdk/lib/core/uri.dart View 1 21 chunks +3091 lines, -1987 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/data_uri_test.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M tests/corelib/uri_test.dart View 1 7 chunks +247 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
4 years, 4 months ago (2016-08-08 10:18:30 UTC) #3
Lasse Reichstein Nielsen
4 years, 4 months ago (2016-08-08 10:18:31 UTC) #4
Bill Hesse
lgtm
4 years, 4 months ago (2016-08-08 10:22:08 UTC) #5
Lasse Reichstein Nielsen
4 years, 4 months ago (2016-08-09 07:40:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
99e94db85b630bcd108ad50723ce12bf9b12757e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698