Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2220363004: Redirect Scope::NewTemporary over parser (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Redirect Scope::NewTemporary over parser BUG=v8:5209 Committed: https://crrev.com/652e1e6d5107376433aafca0da4b0b68a6aad2aa Cr-Commit-Position: refs/heads/master@{#38508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -47 lines) Patch
M src/parsing/parser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 29 chunks +37 lines, -47 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Toon Verwaest
ptal
4 years, 4 months ago (2016-08-09 12:33:31 UTC) #2
adamk
lgtm
4 years, 4 months ago (2016-08-09 17:36:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220363004/1
4 years, 4 months ago (2016-08-09 18:34:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6683)
4 years, 4 months ago (2016-08-09 18:37:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220363004/1
4 years, 4 months ago (2016-08-09 19:12:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 19:49:32 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 19:49:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/652e1e6d5107376433aafca0da4b0b68a6aad2aa
Cr-Commit-Position: refs/heads/master@{#38508}

Powered by Google App Engine
This is Rietveld 408576698