De-virtualize AstString.

De-virtualize AstString & rearrange fields.

This saves memory when parsing.

BUG=

Committed: https://crrev.com/79d9e18cbe746849a6447124ccbaa7611be5d9d6
Cr-Commit-Position: refs/heads/master@{#38434}

[marja, 2016-08-08 08:57:18]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 08:57:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 09:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 09:24:56]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-08-08 09:43:23]

verwaest@chromium.org changed reviewers:
+ verwaest@chromium.org

[Toon Verwaest, 2016-08-08 09:43:24]

looking good. Try to pack the non-pointer fields better though.

https://codereview.chromium.org/2220363002/diff/1/src/ast/ast-value-factory.h
File src/ast/ast-value-factory.h (right):

https://codereview.chromium.org/2220363002/diff/1/src/ast/ast-value-factory.h...
src/ast/ast-value-factory.h:62: bool is_raw_;
You probably want to pack this better with fields in subclasses, using
BitField<>

[marja, 2016-08-08 10:47:19]

Description was changed from

==========
De-virtualize AstString.

It's supposedly faster.

BUG=
==========

to

==========
De-virtualize AstString & rearrange fields.

This saves memory when parsing.

BUG=
==========

[Toon Verwaest, 2016-08-08 10:48:25]

lgtm

[marja, 2016-08-08 10:57:45]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-08-08 10:57:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 11:21:40]

Description was changed from

==========
De-virtualize AstString & rearrange fields.

This saves memory when parsing.

BUG=
==========

to

==========
De-virtualize AstString & rearrange fields.

This saves memory when parsing.

BUG=
==========

[commit-bot: I haz the power, 2016-08-08 11:21:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 11:24:28]

Description was changed from

==========
De-virtualize AstString & rearrange fields.

This saves memory when parsing.

BUG=
==========

to

==========
De-virtualize AstString & rearrange fields.

This saves memory when parsing.

BUG=

Committed: https://crrev.com/79d9e18cbe746849a6447124ccbaa7611be5d9d6
Cr-Commit-Position: refs/heads/master@{#38434}
==========

[commit-bot: I haz the power, 2016-08-08 11:24:28]

Patchset 3 (id:??) landed as
https://crrev.com/79d9e18cbe746849a6447124ccbaa7611be5d9d6
Cr-Commit-Position: refs/heads/master@{#38434}