Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2220333007: Fix Resolution.getResolvedAst for serialization in production mode (Closed)

Created:
4 years, 4 months ago by Johnni Winther
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix Resolution.getResolvedAst for serialization in production mode - and split analysis_test into 4 subtests. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/5af09978e7a0e26e4263c6b93d5842c702aca70b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js/serialization/analysis3_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/compiler/dart2js/serialization/analysis4_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/analysis_test_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 4 months ago (2016-08-09 13:17:39 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 4 months ago (2016-08-09 14:38:39 UTC) #3
Johnni Winther
4 years, 4 months ago (2016-08-10 08:30:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5af09978e7a0e26e4263c6b93d5842c702aca70b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698