Permission Action Reporting: Do not report for Custom Passphrase users.

chrome/browser/permissions/permission_uma_util_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_uma_util.h"
 
 #include "base/test/scoped_command_line.h"
 #include "chrome/browser/signin/fake_signin_manager_builder.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
+#include "chrome/browser/sync/profile_sync_test_util.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/browser_sync/browser/profile_sync_service.h"
+#include "components/browser_sync/browser/profile_sync_service_mock.h"
 #include "components/browser_sync/common/browser_sync_switches.h"
 #include "components/prefs/pref_service.h"
 #include "components/sync/base/model_type.h"
 #include "components/sync/driver/glue/sync_backend_host_mock.h"
 #include "components/sync/driver/sync_prefs.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 constexpr char kTestingGaiaId[] = "gaia_id";
@@ skipping 25 matching lines @@
 
   void SetSafeBrowsing(bool enabled) {
     PrefService* preferences = profile_->GetPrefs();
     preferences->SetBoolean(prefs::kSafeBrowsingEnabled, enabled);
   }
 
   ProfileSyncService* GetProfileSyncService() {
     return ProfileSyncServiceFactory::GetForProfile(profile());
   }
 
+  ProfileSyncServiceMock* SetMockSyncService() {
+    ProfileSyncServiceMock* mock_sync_service =
+        static_cast<ProfileSyncServiceMock*>(
+            ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(
+                profile(), BuildMockProfileSyncService));
+    EXPECT_CALL(*mock_sync_service, CanSyncStart())
+        .WillRepeatedly(testing::Return(true));
+    EXPECT_CALL(*mock_sync_service, IsSyncActive())
+        .WillRepeatedly(testing::Return(true));
+    EXPECT_CALL(*mock_sync_service, IsUsingSecondaryPassphrase())
+        .WillRepeatedly(testing::Return(false));
+
+    syncer::ModelTypeSet preferred_types;
+    preferred_types.Put(syncer::PROXY_TABS);
+    preferred_types.Put(syncer::PRIORITY_PREFERENCES);
+    EXPECT_CALL(*mock_sync_service, GetPreferredDataTypes())
+        .WillRepeatedly(testing::Return(preferred_types));
+
+    return mock_sync_service;
+  }
+
   Profile* profile() { return profile_.get(); }
 
  private:
   content::TestBrowserThreadBundle thread_bundle_;
   std::unique_ptr<TestingProfile> profile_;
 };
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // true if Safe Browsing is enabled, Permission Action Reporting flag is
 // enabled, not in incognito mode and signed in with default sync preferences.
 TEST_F(PermissionUmaUtilTest, IsOptedIntoPermissionActionReportingSignInCheck) {
   base::test::ScopedCommandLine scoped_command_line;
   SetSafeBrowsing(true);
   scoped_command_line.GetProcessCommandLine()->AppendSwitch(
       switches::kEnablePermissionActionReporting);
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 
   FakeSignIn();
+  EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
+
+  SetMockSyncService();
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(
       profile()->GetOffTheRecordProfile()));
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Permission Action Reporting is not enabled.
 TEST_F(PermissionUmaUtilTest, IsOptedIntoPermissionActionReportingFlagCheck) {
   SetSafeBrowsing(true);
   FakeSignIn();
+  SetMockSyncService();
   {
     base::test::ScopedCommandLine scoped_command_line;
     scoped_command_line.GetProcessCommandLine()->AppendSwitch(
         switches::kEnablePermissionActionReporting);
     EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
   }  // Reset the command line.
 
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 
   base::test::ScopedCommandLine scoped_command_line;
   scoped_command_line.GetProcessCommandLine()->AppendSwitch(
       switches::kDisablePermissionActionReporting);
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Safe Browsing is disabled.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingSafeBrowsingCheck) {
   base::test::ScopedCommandLine scoped_command_line;
   scoped_command_line.GetProcessCommandLine()->AppendSwitch(
       switches::kEnablePermissionActionReporting);
   FakeSignIn();
+  SetMockSyncService();
   SetSafeBrowsing(true);
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
   SetSafeBrowsing(false);
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Sync is disabled.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingProfileSyncServiceCheck) {
   base::test::ScopedCommandLine scoped_command_line;
   scoped_command_line.GetProcessCommandLine()->AppendSwitch(
       switches::kEnablePermissionActionReporting);
   SetSafeBrowsing(true);
   FakeSignIn();
+  ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
-  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
-      switches::kDisableSync);
+  EXPECT_CALL(*mock_sync_service, CanSyncStart())
+      .WillOnce(testing::Return(false));

[Nathan Parker, 2016/08/19 00:08:48]

Does this work?  (I assume so).  Like, it overrides the expect_call you applied
in SetMockSyncService?  If so, cool.

[kcarattini, 2016/08/19 01:05:45]

Yup.

   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
 
 // Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
 // false if Tab Sync and Pref Sync are not both enabled.
 TEST_F(PermissionUmaUtilTest,
        IsOptedIntoPermissionActionReportingSyncPreferenceCheck) {
   base::test::ScopedCommandLine scoped_command_line;
   scoped_command_line.GetProcessCommandLine()->AppendSwitch(
       switches::kEnablePermissionActionReporting);
   SetSafeBrowsing(true);
   FakeSignIn();
+  ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
 
-  sync_driver::SyncPrefs sync_prefs(profile()->GetPrefs());
-  const syncer::ModelTypeSet registered_types =
-      GetProfileSyncService()->GetRegisteredDataTypes();
-  sync_prefs.SetKeepEverythingSynced(false);
-
-  sync_prefs.SetPreferredDataTypes(
-      registered_types, syncer::ModelTypeSet(syncer::PROXY_TABS));
+  // Reset the preferred types to return an empty set. The opted-in method will
+  // return false because it needs both Tab and Pref Sync in the preferred types
+  // in order to succeed.
+  syncer::ModelTypeSet preferred_types;
+  EXPECT_CALL(*mock_sync_service, GetPreferredDataTypes())
+      .WillOnce(testing::Return(preferred_types));
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 
-  sync_prefs.SetPreferredDataTypes(
-      registered_types, syncer::ModelTypeSet(syncer::PRIORITY_PREFERENCES));
+  // The opted-in method will be false with only Tab Sync on.
+  preferred_types.Put(syncer::PROXY_TABS);
+  EXPECT_CALL(*mock_sync_service, GetPreferredDataTypes())
+      .WillOnce(testing::Return(preferred_types));
   EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 
-  sync_prefs.SetPreferredDataTypes(
-      registered_types,
-      syncer::ModelTypeSet(syncer::PROXY_TABS, syncer::PRIORITY_PREFERENCES));
+  // The opted-in method will be false with only Pref Sync on.
+  preferred_types.Remove(syncer::PROXY_TABS);
+  preferred_types.Put(syncer::PRIORITY_PREFERENCES);
+  EXPECT_CALL(*mock_sync_service, GetPreferredDataTypes())
+      .WillOnce(testing::Return(preferred_types));
+  EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
+}
+
+// Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
+// false if Sync is not active.
+TEST_F(PermissionUmaUtilTest,
+       IsOptedIntoPermissionActionReportingProfileSyncServiceActiveCheck) {
+  base::test::ScopedCommandLine scoped_command_line;
+  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
+      switches::kEnablePermissionActionReporting);
+  SetSafeBrowsing(true);
+  FakeSignIn();
+  ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
   EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
+
+  EXPECT_CALL(*mock_sync_service, IsSyncActive())
+      .WillOnce(testing::Return(false));
+  EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
 }
+
+// Test that PermissionUmaUtil::IsOptedIntoPermissionActionReporting returns
+// false if a custom Sync passphrase is set.
+TEST_F(PermissionUmaUtilTest,
+       IsOptedIntoPermissionActionReportingSyncPassphraseCheck) {
+  base::test::ScopedCommandLine scoped_command_line;
+  scoped_command_line.GetProcessCommandLine()->AppendSwitch(
+      switches::kEnablePermissionActionReporting);
+  SetSafeBrowsing(true);
+  FakeSignIn();
+  ProfileSyncServiceMock* mock_sync_service = SetMockSyncService();
+  EXPECT_TRUE(IsOptedIntoPermissionActionReporting(profile()));
+
+  EXPECT_CALL(*mock_sync_service, IsUsingSecondaryPassphrase())
+      .WillOnce(testing::Return(true));
+  EXPECT_FALSE(IsOptedIntoPermissionActionReporting(profile()));
+}