MD History: Show 'no synced tabs' when tab sync is disabled

chrome/test/data/webui/md_history/history_synced_tabs_test.js

Index: chrome/test/data/webui/md_history/history_synced_tabs_test.js
diff --git a/chrome/test/data/webui/md_history/history_synced_tabs_test.js b/chrome/test/data/webui/md_history/history_synced_tabs_test.js
index 17b0c4ebefaa60e25b7555211793709d80fe556b..709a50bccde6fd8a8e562a890d539c911debca39 100644
--- a/chrome/test/data/webui/md_history/history_synced_tabs_test.js
+++ b/chrome/test/data/webui/md_history/history_synced_tabs_test.js
@@ -251,7 +251,7 @@ cr.define('md_history.history_synced_tabs_test', function() {
               -1,
               element.$['no-synced-tabs'].textContent.indexOf(noSyncedResults));
 
-          var sessionList = [
+          sessionList = [
             createSession(
                 'Nexus 5',
                 [createWindow(['http://www.google.com', 'http://example.com'])]
@@ -271,6 +271,21 @@ cr.define('md_history.history_synced_tabs_test', function() {
         }).then(function() {
           // When user signs out, don't show the message.
           assertTrue(element.$['no-synced-tabs'].hidden);
+
+          updateSignInState(true);

[tsergeant, 2016/08/08 04:49:15]

Do you mind pulling this out into a separate test()?

You're testing something mostly separate here, and when a single test gets this
long, it's hard to know if anything above is affecting this section of the test.

[lshang, 2016/08/09 00:39:29]

Yep, got rid of the looooooooong test.

+          // Open tabs sync is disabled.
+          setForeignSessions(sessionList, false);
+
+          return flush();
+        }).then(function() {
+          cards = getCards();
+          assertEquals(0, cards.length);
+          // If tab sync is disabled, show 'no synced tabs'.
+          assertFalse(element.$['no-synced-tabs'].hidden);

[tsergeant, 2016/08/08 04:49:15]

Nit: You can pull this code out into a method like

assertNoSyncedTabsMessageShown()

and use it above (line 248) and here.

[lshang, 2016/08/09 00:39:29]

Done.

+          var noSyncedResults = loadTimeData.getString('noSyncedResults');
+          assertNotEquals(
+              -1,
+              element.$['no-synced-tabs'].textContent.indexOf(noSyncedResults));
         });
       });