Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2220243002:
[iOS] Fix EarlGrey public configurations. (Closed)
|
Created:
4 years, 4 months ago by sdefresne Modified:
4 years, 4 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@add-xctest-target Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[iOS] Fix EarlGrey public configurations.
The dependency of //ios/third_party/earl_grey on XCTest is not
exposed in public header, so change it to private config and
instead add the missing dependency to the target needing it.
BUG=629867
Committed: https://crrev.com/773eadb91cc6a1aa5006e2b87771d4de69b7ac01
Cr-Commit-Position: refs/heads/master@{#410861}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase on origin/master #
Messages
Total messages: 27 (22 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [iOS] Fix EarlGrey public configurations. The dependency of //ios/third_party/earl_grey on XCTest is not exposed in public header, so change it to private config and instead add the missing dependency to the target needing it. BUG=None ========== to ========== [iOS] Fix EarlGrey public configurations. The dependency of //ios/third_party/earl_grey on XCTest is not exposed in public header, so change it to private config and instead add the missing dependency to the target needing it. BUG=629867 ==========
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org
Please take a look.
Patchset #1 (id:1) has been deleted
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Patchset #1 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
lgtm
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2220243002/#ps80001 (title: "Rebase on origin/master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [iOS] Fix EarlGrey public configurations. The dependency of //ios/third_party/earl_grey on XCTest is not exposed in public header, so change it to private config and instead add the missing dependency to the target needing it. BUG=629867 ========== to ========== [iOS] Fix EarlGrey public configurations. The dependency of //ios/third_party/earl_grey on XCTest is not exposed in public header, so change it to private config and instead add the missing dependency to the target needing it. BUG=629867 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [iOS] Fix EarlGrey public configurations. The dependency of //ios/third_party/earl_grey on XCTest is not exposed in public header, so change it to private config and instead add the missing dependency to the target needing it. BUG=629867 ========== to ========== [iOS] Fix EarlGrey public configurations. The dependency of //ios/third_party/earl_grey on XCTest is not exposed in public header, so change it to private config and instead add the missing dependency to the target needing it. BUG=629867 Committed: https://crrev.com/773eadb91cc6a1aa5006e2b87771d4de69b7ac01 Cr-Commit-Position: refs/heads/master@{#410861} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/773eadb91cc6a1aa5006e2b87771d4de69b7ac01 Cr-Commit-Position: refs/heads/master@{#410861} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
