Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 222023010: cc: SwapAck throttle Swap without throttling MainFrames (Closed)

Created:
6 years, 8 months ago by brianderson
Modified:
6 years, 7 months ago
Reviewers:
danakj, Sami
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO)
Base URL:
http://git.chromium.org/chromium/src.git@cleanupOutputSurface
Visibility:
Public.

Description

cc: SwapAck throttle Swap without throttling MainFrames This should improve main thread throughput in cases where we are deferring the BeginMainFrame, but don't really need to because the swap ack will come back before the impl thread needs to draw anyway. BUG=311213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266685

Patch Set 1 #

Patch Set 2 : rebase; fix tests #

Patch Set 3 : try again: rebase; fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 2 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brianderson
Depends on: https://codereview.chromium.org/221833009 and the rest.
6 years, 8 months ago (2014-04-03 02:42:01 UTC) #1
Sami
Thanks for splitting this out. lgtm % a simple test?
6 years, 8 months ago (2014-04-08 13:47:32 UTC) #2
danakj
LGTM % test also
6 years, 8 months ago (2014-04-15 15:42:54 UTC) #3
brianderson
The CQ bit was checked by brianderson@chromium.org
6 years, 7 months ago (2014-04-28 18:06:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/222023010/30001
6 years, 7 months ago (2014-04-28 18:07:35 UTC) #5
commit-bot: I haz the power
Change committed as 266685
6 years, 7 months ago (2014-04-28 23:23:48 UTC) #6
Michael Achenbach
6 years, 7 months ago (2014-04-29 07:02:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/255033004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative revert for breaking win7 dbg:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...

Will reland if it didn't help..

Powered by Google App Engine
This is Rietveld 408576698