build/gyp_v8 - Issue 222023004: Make build/gyp_v8 cope with ninja on linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gyp_v8

Issue 222023004: Make build/gyp_v8 cope with ninja on linux (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gyp_v8

diff --git a/build/gyp_v8 b/build/gyp_v8

index f2a60d1b2c8d381b780a89439b16f95d216d5cb7..bc733dfca6fceb3da58e0e7ca5e4a380de1cf03c 100755

--- a/build/gyp_v8

+++ b/build/gyp_v8

@@ -158,7 +158,8 @@ if __name__ == '__main__':

# Generate for the architectures supported on the given platform.

gyp_args = list(args)

- if platform.system() == 'Linux':

+ gyp_generators = os.environ.get('GYP_GENERATORS')

+ if platform.system() == 'Linux' and gyp_generators != 'ninja':

# Work around for crbug.com/331475.

for f in glob.glob(os.path.join(v8_root, 'out', 'Makefile.*')):

os.unlink(f)

« no previous file with comments | « no previous file | no next file » | no next file with comments »