Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 222023004: Make build/gyp_v8 cope with ninja on linux (Closed)

Created:
6 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 8 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Make build/gyp_v8 cope with ninja on linux ninja doesn't support/need the output dir and generator dir flags BUG=v8:3252 R=machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=20462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/gyp_v8 View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-02 14:16:18 UTC) #1
jochen (gone - plz use gerrit)
ptal
6 years, 8 months ago (2014-04-03 06:57:20 UTC) #2
Michael Achenbach
lgtm
6 years, 8 months ago (2014-04-03 07:36:43 UTC) #3
jochen (gone - plz use gerrit)
6 years, 8 months ago (2014-04-03 07:40:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698