LayoutTests/editing/pasteboard/input-with-visibility-hidden.html - Issue 222023002: focus() behaviour differs depending on how value is set

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/pasteboard/input-with-visibility-hidden.html

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adding fix for LayoutTest that are failing Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/editing/pasteboard/input-with-display-none-div.html ('K') | « LayoutTests/editing/pasteboard/input-with-display-none-div.html ('k') | LayoutTests/editing/pasteboard/paste-plaintext-user-select-none.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body style="visibility: hidden;">	3 <body style="visibility: hidden;">

4 <div style="visibility: visible;">	4 <div style="visibility: visible;">

5 <p>This tests pasting (InsertHTML) into an input element when body element has v isibility set to hidden.	5 <p>This tests pasting (InsertHTML) into an input element when body element has v isibility set to hidden.

6 You should see PASS below.</p>	6 You should see PASS below.</p>

7 <input type="text" value="FAIL">	7 <input type="text" value="FAIL">

8 <p><script>	8 <p><script>

9	9

10 if (window.testRunner)	10 if (window.testRunner)

11 testRunner.dumpAsText();	11 testRunner.dumpAsText();

12	12

13 var input = document.querySelector('input');	13 var input = document.querySelector('input');

14 input.focus();	14 input.select();
	tkent 2014/04/11 07:40:20 Ditto. Ditto. harpreet.sk 2014/04/11 08:09:14 For the given layout tests it worked because in th Show quoted text On 2014/04/11 07:40:20, tkent wrote: > Ditto. For the given layout tests it worked because in those case focus() was indirectly calling the select() api which then select the text of input field. So even if we use select() alone it will work .
15 document.execCommand('InsertHTML', false, 'PASS');	15 document.execCommand('InsertHTML', false, 'PASS');

16	16

17 document.write(input.value);	17 document.write(input.value);

18	18

19 </script></p>	19 </script></p>

20 </div>	20 </div>

21 </body>	21 </body>

22 </html>	22 </html>

OLD	NEW