LayoutTests/fast/forms/input-double-click-selection-gap-bug.html - Issue 222023002: focus() behaviour differs depending on how value is set

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/input-double-click-selection-gap-bug.html

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing selection handling of 'value' HTML attribute by initializing m_cachedSelection{Start,End} wi… Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/TestExpectations ('K') | « LayoutTests/fast/forms/focus-selection-input-expected.txt ('k') | LayoutTests/fast/forms/onselect-textfield-expected.txt » ('j') | Source/core/html/HTMLTextFormControlElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.or g/TR/html4/loose.dtd">	1 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.or g/TR/html4/loose.dtd">

2 <html>	2 <html>

3 <head>	3 <head>

4 <title></title>	4 <title></title>

5 <style type="text/css">	5 <style type="text/css">

6 td { padding: 20px; background: lightgreen; }	6 td { padding: 20px; background: lightgreen; }

7 </style>	7 </style>

8 </head>	8 </head>

9 <body>	9 <body>

10 <p>The top table was resized while the field’s contents	10 <p>The top table was resized while the caret postion
	tkent 2014/04/09 00:16:48 The test name contains 'double-click-selection'. The test name contains 'double-click-selection'. I guess we should select the INPUT content. harpreet.sk 2014/04/09 14:19:43 In the given test value set in the input field (ie Show quoted text On 2014/04/09 00:16:48, tkent wrote: > The test name contains 'double-click-selection'. I guess we should select the > INPUT content. > In the given test value set in the input field (ie "foo bar") is not a continuous word and if we double click the input field it should partially selects the word (either foo or either bar) but here it selecting the whole text. I doubt whether the LayoutTest really is for double click selection or for something else. In new patch set i had replaced the focus() with select() so that behavior of this test remains same (ie selection of whole text in input field).
11 were selected.</p>	11 at start of field's content</p>

12 <table>	12 <table>

13 <tr>	13 <tr>

14 <td id="cell">	14 <td id="cell">

15 <input value="foo bar" id="t">	15 <input value="foo bar" id="t">

16 </td>	16 </td>

17 </tr>	17 </tr>

18 </table>	18 </table>

19	19

20 <table>	20 <table>

21 <tr>	21 <tr>

22 <td style="height: 200px;">	22 <td style="height: 200px;">

23 <input value="foo bar">	23 <input value="foo bar">

24 </td>	24 </td>

25 </tr>	25 </tr>

26 </table>	26 </table>

27 </body>	27 </body>

28 <script type="text/javascript">	28 <script type="text/javascript">

29 document.getElementById('t').focus();	29 document.getElementById('t').focus();

30 document.getElementById('cell').style.height = "200px";	30 document.getElementById('cell').style.height = "200px";

31 </script>	31 </script>

32 </html>	32 </html>

OLD	NEW