Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebasing Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 } 330 }
331 331
332 bool HTMLInputElement::shouldShowFocusRingOnMouseFocus() const 332 bool HTMLInputElement::shouldShowFocusRingOnMouseFocus() const
333 { 333 {
334 return m_inputType->shouldShowFocusRingOnMouseFocus(); 334 return m_inputType->shouldShowFocusRingOnMouseFocus();
335 } 335 }
336 336
337 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection) 337 void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection)
338 { 338 {
339 if (isTextField()) { 339 if (isTextField()) {
340 if (!restorePreviousSelection || !hasCachedSelection()) 340 if (!restorePreviousSelection)
341 select(); 341 select();
342 else 342 else
343 restoreCachedSelection(); 343 restoreCachedSelection();
344 if (document().frame()) 344 if (document().frame())
345 document().frame()->selection().revealSelection(); 345 document().frame()->selection().revealSelection();
346 } else 346 } else
347 HTMLTextFormControlElement::updateFocusAppearance(restorePreviousSelecti on); 347 HTMLTextFormControlElement::updateFocusAppearance(restorePreviousSelecti on);
348 } 348 }
349 349
350 void HTMLInputElement::beginEditing() 350 void HTMLInputElement::beginEditing()
(...skipping 1525 matching lines...) Expand 10 before | Expand all | Expand 10 after
1876 } 1876 }
1877 1877
1878 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1878 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1879 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1879 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1880 { 1880 {
1881 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1881 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1882 } 1882 }
1883 #endif 1883 #endif
1884 1884
1885 } // namespace 1885 } // namespace
OLDNEW
« no previous file with comments | « LayoutTests/fast/forms/input-double-click-selection-gap-bug.html ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698