Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2220203002: [ic] Merge LoadGlobalIC_Slow builtins for inside typeof and outside typeof cases. (Closed)

Created:
4 years, 4 months ago by Igor Sheludko
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Merge LoadGlobalIC_Slow builtins for inside typeof and outside typeof cases. ... and let the stub ask the IC whether it should throw or not when the property was not found. This CL undoes ast-numbering changes made here: https://codereview.chromium.org/2219303002/ BUG=chromium:634467 TBR=verwaest@chromium.org Committed: https://crrev.com/b558894ac447108495f5740057e6f999619454fa Cr-Commit-Position: refs/heads/master@{#38549}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+541 lines, -567 lines) Patch
M src/ast/ast-numbering.cc View 1 4 chunks +1 line, -11 lines 0 comments Download
M src/builtins/builtins.h View 1 1 chunk +481 lines, -484 lines 0 comments Download
M src/builtins/builtins-handler.cc View 1 1 chunk +3 lines, -16 lines 0 comments Download
M src/ic/ic.h View 1 1 chunk +1 line, -6 lines 0 comments Download
M src/ic/ic.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 3 chunks +5 lines, -48 lines 0 comments Download

Messages

Total messages: 27 (20 generated)
Igor Sheludko
PTAL (I think this fix is better than the previous one. Sorry for the noise)
4 years, 4 months ago (2016-08-09 19:59:18 UTC) #15
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-10 09:40:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220203002/20001
4 years, 4 months ago (2016-08-10 14:59:02 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21540)
4 years, 4 months ago (2016-08-10 15:02:27 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220203002/20001
4 years, 4 months ago (2016-08-10 16:34:23 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 16:36:05 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 16:36:13 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b558894ac447108495f5740057e6f999619454fa
Cr-Commit-Position: refs/heads/master@{#38549}

Powered by Google App Engine
This is Rietveld 408576698