Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 22202003: Add optional overdraw parameter to skia benchmarking extension (Closed)

Created:
7 years, 4 months ago by egraether
Modified:
7 years, 4 months ago
Reviewers:
f(malita), piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add optional overdraw parameter to skia benchmarking extension This change adds another optional parameter 'overdraw' to the rasterize method of the skia benchmarking extension. When set to true an image with pixel overdraw visualized as heat map is returned. BUG=268342 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215876

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M content/renderer/skia_benchmarking_extension.cc View 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
egraether
Please take a look.
7 years, 4 months ago (2013-08-05 14:06:28 UTC) #1
f(malita)
LGTM. I think you'll need a content owner to rubber stamp this too.
7 years, 4 months ago (2013-08-05 14:20:47 UTC) #2
egraether
On 2013/08/05 14:20:47, Florin Malita wrote: > LGTM. I think you'll need a content owner ...
7 years, 4 months ago (2013-08-05 14:31:00 UTC) #3
f(malita)
On 2013/08/05 14:31:00, egraether wrote: > On 2013/08/05 14:20:47, Florin Malita wrote: > > LGTM. ...
7 years, 4 months ago (2013-08-05 14:37:44 UTC) #4
egraether
+piman, can you take a look as well please?
7 years, 4 months ago (2013-08-05 14:46:03 UTC) #5
piman
lgtm
7 years, 4 months ago (2013-08-05 20:27:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/egraether@chromium.org/22202003/8001
7 years, 4 months ago (2013-08-06 09:39:08 UTC) #7
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 11:46:14 UTC) #8
Message was sent while issue was closed.
Change committed as 215876

Powered by Google App Engine
This is Rietveld 408576698