Issue 2220193002: Implement info.ServiceAccount() on devserver via info.AccessToken(...).

Issue 2220193002: Implement info.ServiceAccount() on devserver via info.AccessToken(...). (Closed)

Created:
4 years, 4 months ago by Vadim Sh.

Modified:
4 years, 4 months ago

Reviewers:
iannucci

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -0 lines)			Patch
	A	impl/prod/devserver.go	View		1 chunk	+89 lines, -0 lines	0 comments	Download
	M	impl/prod/info.go	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Vadim Sh.

PTAL Useful when using delegation tokens locally on devserver. Alternatively, I can plug this in ...

4 years, 4 months ago (2016-08-06 18:15:05 UTC) #1

iannucci

awesome, lgtm I think it's fine in gae, since it doesn't actually rely on luci-go's ...

4 years, 4 months ago (2016-08-06 20:26:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220193002/1

4 years, 4 months ago (2016-08-06 20:31:17 UTC) #4

commit-bot: I haz the power

4 years, 4 months ago (2016-08-06 20:34:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/715e06f753b48ea8e38698e77a8425f115899132