Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2220113002: Make sure no stale LLD checkout is around. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
krasin1, krasin
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure no stale LLD checkout is around. We checked out LLD for a while on all platforms, and now some bots have stale checkouts of it. See bug for details. BUG=635108 Committed: https://crrev.com/f2e30b8c230d923e61752352cf4c37eb13eea3d2 Cr-Commit-Position: refs/heads/master@{#410206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Nico
4 years, 4 months ago (2016-08-05 21:46:18 UTC) #2
krasin
On 2016/08/05 21:46:18, Nico wrote: I actually deleted it from the bots; it could be ...
4 years, 4 months ago (2016-08-05 21:49:32 UTC) #3
krasin
But I like that it's not future-proof. LGTM.
4 years, 4 months ago (2016-08-05 21:50:05 UTC) #4
krasin
Arrrgh. It's *NOW* future-proof
4 years, 4 months ago (2016-08-05 21:50:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220113002/1
4 years, 4 months ago (2016-08-05 21:54:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 23:16:28 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f2e30b8c230d923e61752352cf4c37eb13eea3d2 Cr-Commit-Position: refs/heads/master@{#410206}
4 years, 4 months ago (2016-08-05 23:18:32 UTC) #10
krasin1
4 years, 4 months ago (2016-08-06 01:31:16 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2218313002/ by krasin@chromium.org.

The reason for reverting is: Breaks clang_upload bot:

OSError: [Errno 2] No such file or directory:
'/b/build/slave/linux_upload_clang/build/src/third_party/llvm/tools/lld'

It seems that RmTree requires the directory to exist..

Powered by Google App Engine
This is Rietveld 408576698