Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(794)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 222009: Replace some net::ERR_FAILED generic error codes with more specific codes.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address wtc's comments Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/fetch/fetch_client.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
===================================================================
--- net/url_request/url_request_http_job.cc (revision 26789)
+++ net/url_request/url_request_http_job.cc (working copy)
@@ -564,21 +564,18 @@
DCHECK(request_->context());
DCHECK(request_->context()->http_transaction_factory());
- transaction_.reset(
- request_->context()->http_transaction_factory()->CreateTransaction());
-
// No matter what, we want to report our status as IO pending since we will
// be notifying our consumer asynchronously via OnStartCompleted.
SetStatus(URLRequestStatus(URLRequestStatus::IO_PENDING, 0));
- int rv;
- if (transaction_.get()) {
+ int rv = request_->context()->http_transaction_factory()->CreateTransaction(
+ &transaction_);
+
+ if (rv == net::OK) {
rv = transaction_->Start(
&request_info_, &start_callback_, request_->load_log());
if (rv == net::ERR_IO_PENDING)
return;
- } else {
- rv = net::ERR_FAILED;
}
// The transaction started synchronously, but we need to notify the
« no previous file with comments | « net/tools/fetch/fetch_client.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698