Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Side by Side Diff: net/url_request/url_request_job.cc

Issue 222009: Replace some net::ERR_FAILED generic error codes with more specific codes.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Address wtc's comments Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_job.h" 5 #include "net/url_request/url_request_job.h"
6 6
7 #include "base/message_loop.h" 7 #include "base/message_loop.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "net/base/auth.h" 9 #include "net/base/auth.h"
10 #include "net/base/io_buffer.h" 10 #include "net/base/io_buffer.h"
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 } 295 }
296 case Filter::FILTER_OK: { 296 case Filter::FILTER_OK: {
297 filter_needs_more_output_space_ = 297 filter_needs_more_output_space_ =
298 (filtered_data_len == output_buffer_size); 298 (filtered_data_len == output_buffer_size);
299 *bytes_read = filtered_data_len; 299 *bytes_read = filtered_data_len;
300 rv = true; 300 rv = true;
301 break; 301 break;
302 } 302 }
303 case Filter::FILTER_ERROR: { 303 case Filter::FILTER_ERROR: {
304 filter_needs_more_output_space_ = false; 304 filter_needs_more_output_space_ = false;
305 // TODO(jar): Figure out a better error code. 305 NotifyDone(URLRequestStatus(URLRequestStatus::FAILED,
306 NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, net::ERR_FAILED)); 306 net::ERR_CONTENT_DECODING_FAILED));
307 rv = false; 307 rv = false;
308 break; 308 break;
309 } 309 }
310 default: { 310 default: {
311 NOTREACHED(); 311 NOTREACHED();
312 filter_needs_more_output_space_ = false; 312 filter_needs_more_output_space_ = false;
313 rv = false; 313 rv = false;
314 break; 314 break;
315 } 315 }
316 } 316 }
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 packet_times_[4] - packet_times_[3], 736 packet_times_[4] - packet_times_[3],
737 base::TimeDelta::FromMilliseconds(1), 737 base::TimeDelta::FromMilliseconds(1),
738 base::TimeDelta::FromSeconds(10), 100); 738 base::TimeDelta::FromSeconds(10), 100);
739 return; 739 return;
740 } 740 }
741 default: 741 default:
742 NOTREACHED(); 742 NOTREACHED();
743 return; 743 return;
744 } 744 }
745 } 745 }
OLDNEW
« no previous file with comments | « net/url_request/url_request_http_job.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698