Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2220043002: Added PointerEvent.hasPointerCapture API. (Closed)

Created:
4 years, 4 months ago by mustaq
Modified:
4 years, 4 months ago
Reviewers:
bokan, Navid Zolghadr
CC:
chromium-reviews, dtapuska+blinkwatch_chromium.org, nzolghadr+blinkwatch_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added PointerEvent.hasPointerCapture API. BUG=634512 Committed: https://crrev.com/157602278ef0f09beffd09f2491807fbb19c763e Cr-Commit-Position: refs/heads/master@{#411106}

Patch Set 1 #

Patch Set 2 : Added an entry to global-interface-listing #

Total comments: 1

Patch Set 3 : Added TODOs to merger two tests for w3c tests. #

Patch Set 4 : Rebased, fixed element-instance-property-listing #

Patch Set 5 : Added a missing element interface. #

Messages

Total messages: 27 (15 generated)
mustaq
ptal
4 years, 4 months ago (2016-08-05 20:41:51 UTC) #2
Navid Zolghadr
lgtm https://codereview.chromium.org/2220043002/diff/40001/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-haspointercapture.html File third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-haspointercapture.html (right): https://codereview.chromium.org/2220043002/diff/40001/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-haspointercapture.html#newcode1 third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-haspointercapture.html:1: <!DOCTYPE HTML> General question here. Do you think ...
4 years, 4 months ago (2016-08-08 15:06:05 UTC) #4
mustaq
On 2016/08/08 15:06:05, Navid Zolghadr wrote: > lgtm > > https://codereview.chromium.org/2220043002/diff/40001/third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-haspointercapture.html > File > third_party/WebKit/LayoutTests/fast/events/pointerevents/mouse-pointer-haspointercapture.html ...
4 years, 4 months ago (2016-08-09 15:11:58 UTC) #5
mustaq
bokan@chromium.org: Please review changes in Source/core.
4 years, 4 months ago (2016-08-09 15:13:09 UTC) #7
bokan
lgtm
4 years, 4 months ago (2016-08-09 15:38:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220043002/80001
4 years, 4 months ago (2016-08-09 18:59:31 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/276853)
4 years, 4 months ago (2016-08-09 20:30:52 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220043002/100001
4 years, 4 months ago (2016-08-10 14:57:40 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/49609)
4 years, 4 months ago (2016-08-10 16:16:36 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220043002/100001
4 years, 4 months ago (2016-08-10 16:26:06 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 4 months ago (2016-08-10 18:49:47 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 18:52:13 UTC) #27
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/157602278ef0f09beffd09f2491807fbb19c763e
Cr-Commit-Position: refs/heads/master@{#411106}

Powered by Google App Engine
This is Rietveld 408576698