[webcrypto] Don't throw any extra WebIDL exceptions from WebCrypto methods.

[webcrypto] Don't throw any extra WebIDL exceptions from WebCrypto methods.

The editors draft of WebIDL says that methods which return a Promise should not throw exceptions for such failures, but rather reject the promise with the error.

This behavior is not implemented by the Blink generator yet, so this changelist doesn't completely fix the issue.

However, it does remove some of the synchronous exceptions.

BUG=357723, 245025
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171238

[abarth-chromium, 2014-04-02 20:42:39]

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
File Source/modules/crypto/SubtleCrypto.cpp (right):

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
Source/modules/crypto/SubtleCrypto.cpp:49: // currently doesn't. See also
http://crbug.com/264520
Can we fix the code generator instead of working around the problem here?

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
Source/modules/crypto/SubtleCrypto.cpp:54: StringBuilder strBuilder;
strBuilder -> builder

Please use complete words in variable names.

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
Source/modules/crypto/SubtleCrypto.cpp:58:
result->completeWithError(blink::WebString(String(strBuilder.toString())));
You can just use operator+ instead of string builder.

[eroman, 2014-04-02 23:46:33]

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
File Source/modules/crypto/SubtleCrypto.cpp (right):

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
Source/modules/crypto/SubtleCrypto.cpp:49: // currently doesn't. See also
http://crbug.com/264520
On 2014/04/02 20:42:40, abarth wrote:
> Can we fix the code generator instead of working around the problem here?

Absolutely.

I will take a look at the generator next, which should also be blanket rejecting
promises rather than throwing exceptions.

However I would like to fixup the IDL files here as well as the tests first.

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
Source/modules/crypto/SubtleCrypto.cpp:54: StringBuilder strBuilder;
On 2014/04/02 20:42:40, abarth wrote:
> strBuilder -> builder
> 
> Please use complete words in variable names.

Done.

https://codereview.chromium.org/222003006/diff/70001/Source/modules/crypto/Su...
Source/modules/crypto/SubtleCrypto.cpp:58:
result->completeWithError(blink::WebString(String(strBuilder.toString())));
On 2014/04/02 20:42:40, abarth wrote:
> You can just use operator+ instead of string builder.

Done.

[eroman, 2014-04-10 00:20:01]

ping

[abarth-chromium, 2014-04-10 00:31:15]

LGTM

Sorry for losing track of this CL!

[eroman, 2014-04-10 00:32:28]

No problem! I am always impressed at how quickly you respond to reviews, and
feel guilty pinging :)

[eroman, 2014-04-10 00:42:03]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-10 00:42:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/222003006/110001

[commit-bot: I haz the power, 2014-04-10 01:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 01:28:51]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[eroman, 2014-04-10 01:53:27]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-10 01:53:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/222003006/110001

[commit-bot: I haz the power, 2014-04-10 03:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-10 03:30:44]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[eroman, 2014-04-10 06:10:20]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-04-10 06:10:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/222003006/110001

[commit-bot: I haz the power, 2014-04-10 06:57:08]

Change committed as 171238