Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2220023002: Add API for new Cronet metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments, mostly on javadoc Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
index 9bc276b072817930360d6f0af2a405050b666416..b96cf5d7d46b19a9c2899fa4570792cb7ef0db09 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
@@ -9,9 +9,11 @@ import static org.chromium.base.CollectionUtil.newHashSet;
import android.test.suitebuilder.annotation.SmallTest;
import org.chromium.base.test.util.Feature;
+import org.chromium.net.impl.CronetMetrics;
import org.chromium.net.test.EmbeddedTestServer;
import java.util.ArrayList;
+import java.util.Date;
import java.util.HashSet;
import java.util.LinkedList;
import java.util.List;
@@ -259,4 +261,45 @@ public class RequestFinishedInfoTest extends CronetTestBase {
requestFinishedListener.mRequestInfo);
mTestFramework.mCronetEngine.shutdown();
}
+
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testMetricsGetters() throws Exception {
+ long requestStart = 1;
+ long dnsStart = 2;
+ long dnsEnd = -1;
+ long connectStart = 4;
+ long connectEnd = 5;
+ long sslStart = 6;
+ long sslEnd = 7;
+ long sendingStart = 8;
+ long sendingEnd = 9;
+ long pushStart = 10;
+ long pushEnd = 11;
+ long responseStart = 12;
+ long responseEnd = 13;
+ boolean socketReused = true;
+ long sentBytesCount = 14;
+ long receivedBytesCount = 15;
+ // Make sure nothing gets reordered inside the Metrics class
+ RequestFinishedInfo.Metrics metrics = new CronetMetrics(requestStart, dnsStart, dnsEnd,
+ connectStart, connectEnd, sslStart, sslEnd, sendingStart, sendingEnd, pushStart,
+ pushEnd, responseStart, responseEnd, socketReused, sentBytesCount,
+ receivedBytesCount);
+ assertEquals(new Date(requestStart), metrics.getRequestStart());
+ // -1 timestamp should translate to null
+ assertNull(metrics.getDnsEnd());
+ assertEquals(new Date(dnsStart), metrics.getDnsStart());
+ assertEquals(new Date(connectStart), metrics.getConnectStart());
+ assertEquals(new Date(connectEnd), metrics.getConnectEnd());
+ assertEquals(new Date(sslStart), metrics.getSslStart());
+ assertEquals(new Date(sslEnd), metrics.getSslEnd());
+ assertEquals(new Date(pushStart), metrics.getPushStart());
+ assertEquals(new Date(pushEnd), metrics.getPushEnd());
+ assertEquals(new Date(responseStart), metrics.getResponseStart());
+ assertEquals(new Date(responseEnd), metrics.getResponseEnd());
+ assertEquals(socketReused, metrics.getSocketReused());
+ assertEquals(sentBytesCount, (long) metrics.getSentBytesCount());
+ assertEquals(receivedBytesCount, (long) metrics.getReceivedBytesCount());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698