Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

Issue 2220023002: Add API for new Cronet metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: words Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
index 3dea66d9085208e29436dffd68f3b8e9091f3479..52afc3744099eafb412170514194f809a0133ce1 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java
@@ -49,7 +49,7 @@ import javax.annotation.concurrent.GuardedBy;
@VisibleForTesting
public final class CronetUrlRequest implements UrlRequest {
private static final RequestFinishedInfo.Metrics EMPTY_METRICS =
- new RequestFinishedInfo.Metrics(null, null, null, null);
+ new CronetMetrics(null, null, null, null);
private final boolean mAllowDirectExecutor;
/* Native adapter object, owned by UrlRequest. */
@@ -700,10 +700,11 @@ public final class CronetUrlRequest implements UrlRequest {
}
RequestFinishedInfo getRequestFinishedInfo() {
+ // TODO(mgersh): fill in real values for finishedReason and exception
return new RequestFinishedInfo(mInitialUrl, mRequestAnnotations,
(mRequestMetricsAccumulator != null ? mRequestMetricsAccumulator.getRequestMetrics()
: EMPTY_METRICS),
- mResponseInfo);
+ RequestFinishedInfo.SUCCEEDED, mResponseInfo, null);
}
private final class UrlRequestMetricsAccumulator {
@@ -715,7 +716,7 @@ public final class CronetUrlRequest implements UrlRequest {
private Long mTotalTimeMs;
private RequestFinishedInfo.Metrics getRequestMetrics() {
- return new RequestFinishedInfo.Metrics(mTtfbMs, mTotalTimeMs,
+ return new CronetMetrics(mTtfbMs, mTotalTimeMs,
null, // TODO(klm): Compute sentBytesCount.
(mResponseInfo != null ? mResponseInfo.getReceivedBytesCount() : 0));
}

Powered by Google App Engine
This is Rietveld 408576698