components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java - Issue 2220023002: Add API for new Cronet metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

Issue 2220023002: Add API for new Cronet metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java ('K') | « components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

index d7da13995e5e93778193615b2acd737971a373fa..5710e2d4d62aee3a2a0efb4ea338d7079d76c008 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

@@ -696,10 +696,11 @@ public final class CronetUrlRequest implements UrlRequest {

}

RequestFinishedInfo getRequestFinishedInfo() {

+ // TODO(mgersh): fill in real values for finishedReason and exception

return new RequestFinishedInfo(mInitialUrl, mRequestAnnotations,

(mRequestMetricsAccumulator != null ? mRequestMetricsAccumulator.getRequestMetrics()

: EMPTY_METRICS),

- mResponseInfo);

+ RequestFinishedInfo.SUCCEEDED, mResponseInfo, null);

}

private final class UrlRequestMetricsAccumulator {