Add API for new Cronet metrics

components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import static org.chromium.base.CollectionUtil.newHashSet;
 
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.test.util.Feature;
+import org.chromium.net.impl.CronetMetrics;
 import org.chromium.net.test.EmbeddedTestServer;
 
 import java.util.ArrayList;
+import java.util.Date;
 import java.util.HashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.NoSuchElementException;
 import java.util.concurrent.Executor;
 
 /**
  * Test RequestFinishedInfo.Listener and the metrics information it provides.
  */
 public class RequestFinishedInfoTest extends CronetTestBase {
@@ skipping 227 matching lines @@
         UrlRequest.Builder urlRequestBuilder = new UrlRequest.Builder(
                 mUrl, callback, callback.getExecutor(), mTestFramework.mCronetEngine);
         urlRequestBuilder.build().start();
         callback.blockForDone();
         testExecutor.runAllTasks();
 
         assertNull("RequestFinishedInfo.Listener must not be called",
                 requestFinishedListener.mRequestInfo);
         mTestFramework.mCronetEngine.shutdown();
     }
+
+    @SmallTest
+    @Feature({"Cronet"})
+    public void testMetricsGetters() throws Exception {
+        long requestStart = 1;
+        long dnsStart = 0;
+        long dnsEnd = 3;

[xunjieli, 2016/09/05 23:24:17]

Shouldn't this test case trigger an assertion?
Passing a dnsStart that is > requestStart seems to be a bad argument. I know
that you meant to have dnsStart as a null timestamp, but the JavaDoc doesn't
indicate that it's valid to have a null Start but a non-null End.

To make things clearer, can we pass the null timestamps from C++ to Java as -1
longs? That way it will be easier to add assertions and will allow us to
differentiate between timestamps been 0 and null.
WDYT?

[mgersh, 2016/09/07 22:09:58]

Good point, that wouldn't make any sense if it were real data. And sure, I can
change it to -1.

+        long connectStart = 4;
+        long connectEnd = 5;
+        long sslStart = 6;
+        long sslEnd = 7;
+        long sendingStart = 8;
+        long sendingEnd = 9;
+        long pushStart = 10;
+        long pushEnd = 11;
+        long responseStart = 12;
+        long responseEnd = 13;
+        boolean socketReused = true;
+        long sentBytesCount = 14;
+        long receivedBytesCount = 15;
+        // Make sure nothing gets reordered inside the Metrics class
+        RequestFinishedInfo.Metrics metrics = new CronetMetrics(requestStart, dnsStart, dnsEnd,
+                connectStart, connectEnd, sslStart, sslEnd, sendingStart, sendingEnd, pushStart,
+                pushEnd, responseStart, responseEnd, socketReused, sentBytesCount,
+                receivedBytesCount);
+        assertEquals(new Date(requestStart), metrics.getRequestStart());
+        // 0 timestamp should translate to null, not 1/1/1970
+        assertNull(metrics.getDnsStart());
+        assertEquals(new Date(dnsEnd), metrics.getDnsEnd());
+        assertEquals(new Date(connectStart), metrics.getConnectStart());
+        assertEquals(new Date(connectEnd), metrics.getConnectEnd());
+        assertEquals(new Date(sslStart), metrics.getSslStart());
+        assertEquals(new Date(sslEnd), metrics.getSslEnd());
+        assertEquals(new Date(pushStart), metrics.getPushStart());
+        assertEquals(new Date(pushEnd), metrics.getPushEnd());
+        assertEquals(new Date(responseStart), metrics.getResponseStart());
+        assertEquals(new Date(responseEnd), metrics.getResponseEnd());
+        assertEquals(socketReused, metrics.getSocketReused());
+        assertEquals(sentBytesCount, (long) metrics.getSentBytesCount());
+        assertEquals(receivedBytesCount, (long) metrics.getReceivedBytesCount());
+    }
 }