Add @TargetApi to version dependent methods.

Add @TargetApi to version dependent methods.

Adding the @TargetApi annotation to methods that require newer features
of android will remove lint warnings while ensuring that the warnings
will return if anything is referenced above the API level specified in
the annotation.

BUG=634948
Committed: https://crrev.com/3c1222abf89c8f46438f9c917921f77cb959d3c0
Cr-Commit-Position: refs/heads/master@{#410771}

[estevenson, 2016-08-05 18:33:59]

Description was changed from

==========
Add @TargetApi to version dependent methods.

Adding the @TargetApi annotation to methods that require newer features
of android will remove lint warnings while ensuring that the warnings
will return if anything is referenced above the API level specified in
the annotation.

BUG=607761
==========

to

==========
Add @TargetApi to version dependent methods.

Adding the @TargetApi annotation to methods that require newer features
of android will remove lint warnings while ensuring that the warnings
will return if anything is referenced above the API level specified in
the annotation.

BUG=634948
==========

[estevenson, 2016-08-05 19:01:10]

estevenson@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[estevenson, 2016-08-05 19:01:10]

Trying to get rid of some lint warnings, ptal!

[Maria, 2016-08-05 23:42:07]

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1509:
@TargetApi(Build.VERSION_CODES.M)
I think this would work with L and above.

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
(right):

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java:245:
@TargetApi(Build.VERSION_CODES.M)
I think this would work with L and above

[estevenson, 2016-08-08 14:23:49]

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
(right):

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:1509:
@TargetApi(Build.VERSION_CODES.M)
On 2016/08/05 23:42:06, Maria wrote:
> I think this would work with L and above.

It looks like ActivityManager.RecentTaskInfo.baseActivity was added in M if I'm
not mistaken?
https://developer.android.com/reference/android/app/ActivityManager.RecentTas...

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java
(right):

https://codereview.chromium.org/2219993002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/multiwindow/MultiWindowUtils.java:245:
@TargetApi(Build.VERSION_CODES.M)
On 2016/08/05 23:42:06, Maria wrote:
> I think this would work with L and above

Same as ChromeTabbedActivity, it looks like
ActivityManager.RecentTaskInfo.baseActivity was added in M
https://developer.android.com/reference/android/app/ActivityManager.RecentTas....

https://codereview.chromium.org/2219993002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
(right):

https://codereview.chromium.org/2219993002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:75:
@TargetApi(24)
This only needs to be JELLY_BEAN_MR1 (for applyOverrideConfiguration) but since
this code will only run in N it's probably best to have it at 24?

[Maria, 2016-08-09 18:22:46]

lgtm

https://codereview.chromium.org/2219993002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
(right):

https://codereview.chromium.org/2219993002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:75:
@TargetApi(24)
On 2016/08/08 14:23:49, Eric Stevenson wrote:
> This only needs to be JELLY_BEAN_MR1 (for applyOverrideConfiguration) but
since
> this code will only run in N it's probably best to have it at 24?

Yes, this makes sense to me

[estevenson, 2016-08-09 18:27:53]

The CQ bit was checked by estevenson@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:28:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 18:31:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 18:31:20]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[estevenson, 2016-08-09 18:40:00]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-08-09 18:40:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2219993002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-09 18:40:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 19:46:49]

Description was changed from

==========
Add @TargetApi to version dependent methods.

Adding the @TargetApi annotation to methods that require newer features
of android will remove lint warnings while ensuring that the warnings
will return if anything is referenced above the API level specified in
the annotation.

BUG=634948
==========

to

==========
Add @TargetApi to version dependent methods.

Adding the @TargetApi annotation to methods that require newer features
of android will remove lint warnings while ensuring that the warnings
will return if anything is referenced above the API level specified in
the annotation.

BUG=634948
==========

[commit-bot: I haz the power, 2016-08-09 19:46:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-09 19:48:35]

Description was changed from

==========
Add @TargetApi to version dependent methods.

Adding the @TargetApi annotation to methods that require newer features
of android will remove lint warnings while ensuring that the warnings
will return if anything is referenced above the API level specified in
the annotation.

BUG=634948
==========

to

==========
Add @TargetApi to version dependent methods.

Adding the @TargetApi annotation to methods that require newer features
of android will remove lint warnings while ensuring that the warnings
will return if anything is referenced above the API level specified in
the annotation.

BUG=634948

Committed: https://crrev.com/3c1222abf89c8f46438f9c917921f77cb959d3c0
Cr-Commit-Position: refs/heads/master@{#410771}
==========

[commit-bot: I haz the power, 2016-08-09 19:48:36]

Patchset 3 (id:??) landed as
https://crrev.com/3c1222abf89c8f46438f9c917921f77cb959d3c0
Cr-Commit-Position: refs/heads/master@{#410771}