Refactor download image-MIME-type-detection code.

Refactor download image-MIME-type-detection code.

Refactor duplicated image-MIME-type-detection code from
DownloadCommands and DownloadItemNotification into a new
DownloadItemModel::HasSupportedImageMimeType() method.

BUG=605805
Committed: https://crrev.com/759969dbc064ab0925287ad8a62eacf588faec7f
Cr-Commit-Position: refs/heads/master@{#410382}

[Daniel Erat, 2016-08-05 23:46:27]

derat@chromium.org changed reviewers:
+ rdsmith@chromium.org

[Daniel Erat, 2016-08-05 23:48:44]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:49:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 00:27:28]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Daniel Erat, 2016-08-06 00:39:07]

The CQ bit was checked by derat@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-06 00:39:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 01:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 01:19:45]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2016-08-08 14:42:52]

rdsmith@chromium.org changed reviewers:
+ svaldez@chromium.org

[Randy Smith (Not in Mondays), 2016-08-08 14:42:52]

LGTM, but I'd like to also get an LGTM from Steve, who's been working in this
code more recently than I.  Steven?

[svaldez, 2016-08-08 15:07:52]

Just a note on additional test cases, but otherwise LGTM.

https://codereview.chromium.org/2219953004/diff/20001/chrome/browser/download...
File chrome/browser/download/download_item_model_unittest.cc (right):

https://codereview.chromium.org/2219953004/diff/20001/chrome/browser/download...
chrome/browser/download/download_item_model_unittest.cc:400:
EXPECT_TRUE(model().HasSupportedImageMimeType());
Can you add a test for /foo/image.txt returning false, and "/foo/image." doing
the right thing.

[Daniel Erat, 2016-08-08 16:02:14]

thanks for the quick review!

https://codereview.chromium.org/2219953004/diff/20001/chrome/browser/download...
File chrome/browser/download/download_item_model_unittest.cc (right):

https://codereview.chromium.org/2219953004/diff/20001/chrome/browser/download...
chrome/browser/download/download_item_model_unittest.cc:400:
EXPECT_TRUE(model().HasSupportedImageMimeType());
On 2016/08/08 15:07:52, svaldez wrote:
> Can you add a test for /foo/image.txt returning false, and "/foo/image." doing
> the right thing. 

Done.

[Daniel Erat, 2016-08-08 16:02:38]

The CQ bit was checked by derat@chromium.org

[Daniel Erat, 2016-08-08 16:02:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
svaldez@chromium.org, rdsmith@chromium.org
Link to the patchset: https://codereview.chromium.org/2219953004/#ps40001
(title: "add more tests")

[commit-bot: I haz the power, 2016-08-08 16:03:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:48:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-08 16:51:17]

Description was changed from

==========
Refactor download image-MIME-type-detection code.

Refactor duplicated image-MIME-type-detection code from
DownloadCommands and DownloadItemNotification into a new
DownloadItemModel::HasSupportedImageMimeType() method.

BUG=605805
==========

to

==========
Refactor download image-MIME-type-detection code.

Refactor duplicated image-MIME-type-detection code from
DownloadCommands and DownloadItemNotification into a new
DownloadItemModel::HasSupportedImageMimeType() method.

BUG=605805

Committed: https://crrev.com/759969dbc064ab0925287ad8a62eacf588faec7f
Cr-Commit-Position: refs/heads/master@{#410382}
==========

[commit-bot: I haz the power, 2016-08-08 16:51:17]

Patchset 3 (id:??) landed as
https://crrev.com/759969dbc064ab0925287ad8a62eacf588faec7f
Cr-Commit-Position: refs/heads/master@{#410382}

[Daniel Erat, 2016-08-08 18:49:11]

argh, committed some code that i didn't intend to by re-uploading without
telling git-cl to diff against an intermediate branch. i'll revert.

[Daniel Erat, 2016-08-08 18:49:41]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2221113003/ by derat@chromium.org.

The reason for reverting is: accidentally mixed in another change
(https://codereview.chromium.org/2225543002/).