Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2966)

Unified Diff: build/toolchain/nacl_toolchain.gni

Issue 2219953002: Use new toolchain_args variable in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@toolchain_args
Patch Set: wrap Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/nacl/BUILD.gn ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/nacl_toolchain.gni
diff --git a/build/toolchain/nacl_toolchain.gni b/build/toolchain/nacl_toolchain.gni
index ea4c5ec69e77bd2cb61392b6c5a066fe96fce8dc..eb6ffcce0c0bf687483c24ed7192f5c60bd67460 100644
--- a/build/toolchain/nacl_toolchain.gni
+++ b/build/toolchain/nacl_toolchain.gni
@@ -12,25 +12,19 @@ import("//build/toolchain/gcc_toolchain.gni")
# - cxx
# - ar
# - ld
-# and the following which is used in the toolchain_args
-# - toolchain_cpu (What "current_cpu" should be set to when invoking a
-# build using this toolchain.)
template("nacl_toolchain") {
assert(defined(invoker.cc), "nacl_toolchain() must specify a \"cc\" value")
assert(defined(invoker.cxx), "nacl_toolchain() must specify a \"cxx\" value")
assert(defined(invoker.ar), "nacl_toolchain() must specify a \"ar\" value")
assert(defined(invoker.ld), "nacl_toolchain() must specify a \"ld\" value")
- assert(defined(invoker.toolchain_cpu),
- "nacl_toolchain() must specify a \"toolchain_cpu\"")
gcc_toolchain(target_name) {
- toolchain_os = "nacl"
-
if (defined(invoker.executable_extension)) {
executable_extension = invoker.executable_extension
} else {
executable_extension = ".nexe"
}
+ rebuild_define = "NACL_TC_REV=" + invoker.toolchain_revision
forward_variables_from(invoker,
[
@@ -43,25 +37,19 @@ template("nacl_toolchain") {
"nm",
"readelf",
"strip",
- "toolchain_cpu",
])
- if (defined(invoker.is_clang)) {
- is_clang = invoker.is_clang
- }
- if (defined(invoker.is_nacl_glibc)) {
- is_nacl_glibc = invoker.is_nacl_glibc
- }
- if (defined(invoker.symbol_level)) {
- symbol_level = invoker.symbol_level
- }
+ toolchain_args = {
+ # Use all values set on the invoker's toolchain_args.
+ forward_variables_from(invoker.toolchain_args, "*")
- # We do not support component builds with the NaCl toolchains.
- is_component_build = false
+ current_os = "nacl"
- # We do not support tcmalloc in the NaCl toolchains.
- use_allocator = "none"
+ # We do not support component builds with the NaCl toolchains.
+ is_component_build = false
- rebuild_define = "NACL_TC_REV=" + invoker.toolchain_revision
+ # We do not support tcmalloc in the NaCl toolchains.
+ use_allocator = "none"
+ }
}
}
« no previous file with comments | « build/toolchain/nacl/BUILD.gn ('k') | build/toolchain/win/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698