Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2711)

Unified Diff: base/android/jni_generator/testSingleJNIAdditionalImport.golden

Issue 2219923002: JNI: allow either JavaRef or bare objects in Java calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unreachable line Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_generator/testNativeExportsOnlyOption.golden ('k') | base/android/scoped_java_ref.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_generator/testSingleJNIAdditionalImport.golden
diff --git a/base/android/jni_generator/testSingleJNIAdditionalImport.golden b/base/android/jni_generator/testSingleJNIAdditionalImport.golden
index db61dec51ecc06b6299f919b2f56d72f0b798a7d..3f8c18e8542f4f104c0d2beb73b2d6338a821641 100644
--- a/base/android/jni_generator/testSingleJNIAdditionalImport.golden
+++ b/base/android/jni_generator/testSingleJNIAdditionalImport.golden
@@ -39,7 +39,8 @@ void Java_org_chromium_foo_Foo_nativeDoSomething(JNIEnv* env, jclass jcaller,
}
static base::subtle::AtomicWord g_Foo_calledByNative = 0;
-static void Java_Foo_calledByNative(JNIEnv* env, jobject callback) {
+static void Java_Foo_calledByNative(JNIEnv* env, const
+ base::android::JavaRefOrBare<jobject>& callback) {
CHECK_CLAZZ(env, Foo_clazz(env),
Foo_clazz(env));
jmethodID method_id =
@@ -55,7 +56,7 @@ static void Java_Foo_calledByNative(JNIEnv* env, jobject callback) {
&g_Foo_calledByNative);
env->CallStaticVoidMethod(Foo_clazz(env),
- method_id, callback);
+ method_id, callback.obj());
jni_generator::CheckException(env);
}
« no previous file with comments | « base/android/jni_generator/testNativeExportsOnlyOption.golden ('k') | base/android/scoped_java_ref.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698