Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: base/android/scoped_java_ref.cc

Issue 2219923002: JNI: allow either JavaRef or bare objects in Java calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unreachable line Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/android/scoped_java_ref.h" 5 #include "base/android/scoped_java_ref.h"
6 6
7 #include "base/android/jni_android.h" 7 #include "base/android/jni_android.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace base { 10 namespace base {
11 namespace android { 11 namespace android {
12 namespace { 12 namespace {
13 13
14 const int kDefaultLocalFrameCapacity = 16; 14 const int kDefaultLocalFrameCapacity = 16;
15 15
16 } // namespace 16 } // namespace
17 17
18 ScopedJavaLocalFrame::ScopedJavaLocalFrame(JNIEnv* env) : env_(env) { 18 ScopedJavaLocalFrame::ScopedJavaLocalFrame(JNIEnv* env) : env_(env) {
19 int failed = env_->PushLocalFrame(kDefaultLocalFrameCapacity); 19 int failed = env_->PushLocalFrame(kDefaultLocalFrameCapacity);
20 DCHECK(!failed); 20 DCHECK(!failed);
21 } 21 }
22 22
23 ScopedJavaLocalFrame::ScopedJavaLocalFrame(JNIEnv* env, int capacity) 23 ScopedJavaLocalFrame::ScopedJavaLocalFrame(JNIEnv* env, int capacity)
24 : env_(env) { 24 : env_(env) {
25 int failed = env_->PushLocalFrame(capacity); 25 int failed = env_->PushLocalFrame(capacity);
26 DCHECK(!failed); 26 DCHECK(!failed);
27 } 27 }
28 28
29 ScopedJavaLocalFrame::~ScopedJavaLocalFrame() { env_->PopLocalFrame(NULL); } 29 ScopedJavaLocalFrame::~ScopedJavaLocalFrame() {
30 env_->PopLocalFrame(nullptr);
31 }
30 32
31 #if DCHECK_IS_ON() 33 #if DCHECK_IS_ON()
32 // This constructor is inlined when DCHECKs are disabled; don't add anything 34 // This constructor is inlined when DCHECKs are disabled; don't add anything
33 // else here. 35 // else here.
34 JavaRef<jobject>::JavaRef(JNIEnv* env, jobject obj) : obj_(obj) { 36 JavaRef<jobject>::JavaRef(JNIEnv* env, jobject obj) : obj_(obj) {
35 if (obj) { 37 if (obj) {
36 DCHECK(env && env->GetObjectRefType(obj) == JNILocalRefType); 38 DCHECK(env && env->GetObjectRefType(obj) == JNILocalRefType);
37 } 39 }
38 } 40 }
39 #endif 41 #endif
(...skipping 22 matching lines...) Expand all
62 obj = env->NewGlobalRef(obj); 64 obj = env->NewGlobalRef(obj);
63 if (obj_) 65 if (obj_)
64 env->DeleteGlobalRef(obj_); 66 env->DeleteGlobalRef(obj_);
65 obj_ = obj; 67 obj_ = obj;
66 } 68 }
67 69
68 void JavaRef<jobject>::ResetLocalRef(JNIEnv* env) { 70 void JavaRef<jobject>::ResetLocalRef(JNIEnv* env) {
69 if (obj_) { 71 if (obj_) {
70 DCHECK_EQ(env, AttachCurrentThread()); // Is |env| on correct thread. 72 DCHECK_EQ(env, AttachCurrentThread()); // Is |env| on correct thread.
71 env->DeleteLocalRef(obj_); 73 env->DeleteLocalRef(obj_);
72 obj_ = NULL; 74 obj_ = nullptr;
73 } 75 }
74 } 76 }
75 77
76 void JavaRef<jobject>::ResetGlobalRef() { 78 void JavaRef<jobject>::ResetGlobalRef() {
77 if (obj_) { 79 if (obj_) {
78 AttachCurrentThread()->DeleteGlobalRef(obj_); 80 AttachCurrentThread()->DeleteGlobalRef(obj_);
79 obj_ = NULL; 81 obj_ = nullptr;
80 } 82 }
81 } 83 }
82 84
83 jobject JavaRef<jobject>::ReleaseInternal() { 85 jobject JavaRef<jobject>::ReleaseInternal() {
84 jobject obj = obj_; 86 jobject obj = obj_;
85 obj_ = NULL; 87 obj_ = nullptr;
86 return obj; 88 return obj;
87 } 89 }
88 90
89 } // namespace android 91 } // namespace android
90 } // namespace base 92 } // namespace base
OLDNEW
« no previous file with comments | « base/android/scoped_java_ref.h ('k') | chrome/browser/android/preferences/website_preference_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698