JNI: allow either JavaRef or bare objects in Java calls.

JNI: allow either JavaRef or bare objects in Java calls.

Introduce a temporary type JavaRefOrBare which can be constructed from
either a JavaRef or a bare object, and use it as the parameter type for
Java function stubs generated by the JNI generator.

This allows Java functions to be called using a mixture of both types,
so we can incrementally move to using JavaRef only.

Also replace NULL with nullptr in scoped_java_ref.{h,cc} as the
inconsistency looked weird.

BUG=506850
Committed: https://crrev.com/8a372f72544bab76e3a745170e9497f54e211fe5
Cr-Commit-Position: refs/heads/master@{#410377}

[Torne, 2016-08-05 16:27:34]

torne@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Torne, 2016-08-05 16:27:35]

Compared release binary size for libchrome.so and it causes a few extra stack
allocations to pass-by-reference (to the total of about 400 bytes of code size)
- some of this might go away when the refactoring is over and we've eliminated
some more of the conversions back and forth, but some of it might just stay when
we pass const JavaRef&. Probably okay.

This is sufficient to make it pretty easy to switch GetApplicationContext to
return a JavaRef, since almost all usage of that was as a Java method parameter
and only a few changes were required (will upload a followup CL).

[Torne, 2016-08-05 16:27:42]

The CQ bit was checked by torne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 16:28:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 18:02:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 18:02:43]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rmcilroy, 2016-08-08 13:08:29]

LGTM with a comment.

https://codereview.chromium.org/2219923002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/2219923002/diff/1/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:1041: c_type =
JavaDataTypeToC(java_type)
is this line meant to be here? looks unused (and wrongly indented).

[Torne, 2016-08-08 13:34:24]

https://codereview.chromium.org/2219923002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/2219923002/diff/1/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:1041: c_type =
JavaDataTypeToC(java_type)
On 2016/08/08 13:08:29, rmcilroy wrote:
> is this line meant to be here? looks unused (and wrongly indented).

No, that's a copypaste error I guess from the chunk above. It's unneeded and
unreachable, I've just deleted it.

[Torne, 2016-08-08 13:34:48]

torne@chromium.org changed reviewers:
+ bauerb@chromium.org

[Torne, 2016-08-08 13:34:51]

+bauerb for chrome/browser/android OWNERS

[Bernhard Bauer, 2016-08-08 15:46:25]

lgtm

[Torne, 2016-08-08 15:46:52]

The CQ bit was checked by torne@chromium.org

[Torne, 2016-08-08 15:46:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2219923002/#ps20001
(title: "Remove unreachable line")

[commit-bot: I haz the power, 2016-08-08 15:47:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:29:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-08 16:34:39]

Description was changed from

==========
JNI: allow either JavaRef or bare objects in Java calls.

Introduce a temporary type JavaRefOrBare which can be constructed from
either a JavaRef or a bare object, and use it as the parameter type for
Java function stubs generated by the JNI generator.

This allows Java functions to be called using a mixture of both types,
so we can incrementally move to using JavaRef only.

Also replace NULL with nullptr in scoped_java_ref.{h,cc} as the
inconsistency looked weird.

BUG=506850
==========

to

==========
JNI: allow either JavaRef or bare objects in Java calls.

Introduce a temporary type JavaRefOrBare which can be constructed from
either a JavaRef or a bare object, and use it as the parameter type for
Java function stubs generated by the JNI generator.

This allows Java functions to be called using a mixture of both types,
so we can incrementally move to using JavaRef only.

Also replace NULL with nullptr in scoped_java_ref.{h,cc} as the
inconsistency looked weird.

BUG=506850

Committed: https://crrev.com/8a372f72544bab76e3a745170e9497f54e211fe5
Cr-Commit-Position: refs/heads/master@{#410377}
==========

[commit-bot: I haz the power, 2016-08-08 16:34:40]

Patchset 2 (id:??) landed as
https://crrev.com/8a372f72544bab76e3a745170e9497f54e211fe5
Cr-Commit-Position: refs/heads/master@{#410377}