Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2219913002: Reland of Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants (Closed)

Created:
4 years, 4 months ago by Xianzhu
Modified:
4 years, 4 months ago
Reviewers:
chrishtr, trchen, anthonyvd
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, telemetry-reviews_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants (patchset #1 id:1 of https://codereview.chromium.org/2219903002/ ) Reason for revert: Fix conflict. Original issue's description: > Revert of Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants (patchset #5 id:80001 of https://codereview.chromium.org/2214253002/ ) > > Reason for revert: > Reverting this CL because it appears to be breaking the following bot: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/164802 > > Original issue's description: > > Don't traverse non-stacked layer under composited child in traverseNonCompositingDescendants > > > > Non-stacked layers under a composited object belong to the object, so > > we should not traverse them in traverseNonCompositingDescendants. > > > > BUG=634389 > > TEST=LayoutObjectTest.TraverseNonCompositingDescendantsInPaintOrder > > TBR=nednguyen (for enabling the system health smoke test) > > > > Committed: https://crrev.com/6f716f1637685a30fd65cdec3a6b130690d56dbf > > Cr-Commit-Position: refs/heads/master@{#410070} > > TBR=chrishtr@chromium.org,trchen@chromium.org,wangxianzhu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=634389 > > Committed: https://crrev.com/2a98b93fe02a0d09bf32e9ffb96879ba63b08634 > Cr-Commit-Position: refs/heads/master@{#410073} TBR=chrishtr@chromium.org,trchen@chromium.org,anthonyvd@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=634389 Committed: https://crrev.com/014f83a2957cac7f59d6e3652fb07271bb0e0fe5 Cr-Commit-Position: refs/heads/master@{#410102}

Patch Set 1 #

Patch Set 2 : Fix conflict (after JSONValues change) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -35 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 4 chunks +37 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp View 1 2 chunks +41 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/system_health_smoke_test.py View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Xianzhu
4 years, 4 months ago (2016-08-05 16:17:21 UTC) #1
Created Reland of Don't traverse non-stacked layer under composited child in
traverseNonCompositingDescendants

Powered by Google App Engine
This is Rietveld 408576698